Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A naive fix for #212408:
this.isWindows
check to line 835 ofsimpleFileDialog.ts
(based on line 824 of the same file)
notes/toughts:
it assumes the
this.isWindows
also applies to the file service that provides the dirstat (i haven't had the time to investigate how the services instantiated by the dialog are related in code)this IMO may require more work either in
simpleFileDialog
(like trying totocuh
the destination in aPromise
, and returning that) or thefileService
(extra flags)→ any comments, pointers, suggestions and help welcome! - this being my first PR to the codebase
remoteFileDialog.validateReadonlyFolder
should be renamedremoteFileDialog.validateLockedFolder
for correctness, while possibly alteringremoteFileDialog.validateReadonlyFolder
or both to be more concise (if possible?)