Fix traffic light centering on macOS #212471
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here are two screenshots showing the result (with and without command center enabled): 
|
| @@ -377,7 +377,7 @@ export abstract class BaseWindow extends Disposable implements IBaseWindow { | |||
|
|
|||
| // macOS: traffic lights | |||
| else if (isMacintosh && options.height !== undefined) { | |||
| const verticalOffset = (options.height - 15) / 2; // 15px is the height of the traffic lights | |||
| const verticalOffset = Math.floor((options.height - 16) / 2); // 16px is the height of the traffic lights | |||
There was a problem hiding this comment.
Set traffic light height as const. Useless comment that could be explained in code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #208226.
This PR makes two changes to the traffic light centering logic for macOS (see the linked issue for a screenshot of the problem):
12px. A margin of2pxis added at the top and bottom, so the total height for centering is16px.(options.height - 16) / 2is also odd. In this case, Electron rounds up the value. To make the offset look better, the value is rounded down instead.