Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make List / Tree Hovers Focusable #212818

Merged
merged 3 commits into from
May 15, 2024
Merged

Make List / Tree Hovers Focusable #212818

merged 3 commits into from
May 15, 2024

Conversation

benibenj
Copy link
Contributor

@benibenj benibenj commented May 15, 2024

With the addition of support for triggering custom hovers in lists and trees using the Ctrl K + Ctrl I keybinding, this pull request makes the hovers focusable. Previously, it was not possible to set focus into the hover. This change allows users to interact with the hover content using keyboard navigation and after closing the hover, placing the focus back where it previously was.

fixes #211951

@benibenj benibenj self-assigned this May 15, 2024
@benibenj benibenj enabled auto-merge (squash) May 15, 2024 15:08
@VSCodeTriageBot VSCodeTriageBot added this to the May 2024 milestone May 15, 2024
@benibenj benibenj disabled auto-merge May 15, 2024 15:12
aeschli
aeschli previously approved these changes May 15, 2024
@benibenj benibenj merged commit c924205 into main May 15, 2024
6 checks passed
@benibenj benibenj deleted the benibenj/scrawny-squirrel branch May 15, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make List / Tree Hovers Focusable
4 participants