Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: two-phase retrieval on lru-segment #32945

Merged
merged 5 commits into from May 15, 2024

Conversation

longjiquan
Copy link
Contributor

issue: #31822

@sre-ci-robot sre-ci-robot requested review from aoiasd and yah01 May 10, 2024 08:28
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label May 10, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels May 10, 2024
@longjiquan
Copy link
Contributor Author

/hold

Copy link
Contributor

mergify bot commented May 10, 2024

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@longjiquan
Copy link
Contributor Author

/run-cpu-e2e

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
Copy link
Contributor

mergify bot commented May 10, 2024

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
Copy link
Contributor

mergify bot commented May 10, 2024

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
Signed-off-by: longjiquan <jiquan.long@zilliz.com>
Signed-off-by: longjiquan <jiquan.long@zilliz.com>
Copy link
Contributor

mergify bot commented May 13, 2024

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@longjiquan
Copy link
Contributor Author

/run-cpu-e2e

Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 55.22388% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 82.11%. Comparing base (293f14a) to head (284191c).
Report is 29 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32945      +/-   ##
==========================================
+ Coverage   82.06%   82.11%   +0.05%     
==========================================
  Files        1007      999       -8     
  Lines      127699   127943     +244     
==========================================
+ Hits       104793   105066     +273     
+ Misses      18931    18905      -26     
+ Partials     3975     3972       -3     
Files Coverage Δ
...rnal/querynodev2/segments/default_limit_reducer.go 100.00% <100.00%> (ø)
internal/querynodev2/segments/reducer.go 100.00% <100.00%> (ø)
internal/querynodev2/tasks/query_task.go 91.75% <100.00%> (+0.08%) ⬆️
internal/querynodev2/segments/retrieve.go 85.43% <86.66%> (+6.98%) ⬆️
internal/querynodev2/segments/result.go 74.04% <25.00%> (-0.72%) ⬇️
internal/querynodev2/segments/segment_do.go 38.88% <38.88%> (ø)

... and 217 files with indirect coverage changes

@aoiasd
Copy link
Contributor

aoiasd commented May 13, 2024

/lgtm

Copy link
Contributor

mergify bot commented May 13, 2024

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@longjiquan
Copy link
Contributor Author

/run-cpu-e2e

@czs007
Copy link
Contributor

czs007 commented May 15, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, longjiquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@longjiquan
Copy link
Contributor Author

/unhold

@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels May 15, 2024
@sre-ci-robot sre-ci-robot merged commit dd9919a into milvus-io:master May 15, 2024
14 of 15 checks passed
@longjiquan longjiquan deleted the query-stream-reduce branch May 17, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants