Clean up github actions #8902
Merged
Clean up github actions #8902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishfagg
changed the title
lucas-koontz
approved these changes
Mar 20, 2024
Comment on lines
+50
to
+108
| - name: Run integration api and flow tests | ||
| run: | | ||
|
|
||
| if [ "$RUNNER_OS" == "Linux" ]; then | ||
|
|
||
| mkdir prometheus_metrics | ||
|
|
||
| pytest -vx tests/integration_tests/flows/test_ml_task_queue.py | ||
|
|
||
| # MySQL API | ||
| echo -e "\n===============test MySQL API===============\n" | ||
| pytest -vx tests/integration_tests/flows/test_mysql_api.py | ||
|
|
||
| # MySQL binary API | ||
| echo -e "\n===============test MySQL binary API===============\n" | ||
| pytest -vx -k 'not TestMySqlApi' tests/integration_tests/flows/test_mysql_bin_api.py | ||
|
|
||
| # echo -e "\n===============TS predictions===============\n" | ||
| pytest -svx tests/integration_tests/flows/test_ts_predictions.py | ||
|
|
||
| # HTTP | ||
| echo -e "\n===============test HTTP===============\n" | ||
| pytest -vx tests/integration_tests/flows/test_http.py | ||
|
|
||
| # Company independent | ||
| echo -e "\n===============test company independent===============\n" | ||
| pytest -vx tests/integration_tests/flows/test_company_independent.py | ||
| fi | ||
| env: | ||
| PROMETHEUS_MULTIPROC_DIR: ./prometheus_metrics | ||
| CHECK_FOR_UPDATES: False | ||
|
|
||
| - name: Run Learning Hub Tests | ||
| run: | | ||
| # Currently requires a DB to be running. New testing system is being set up | ||
| # echo -e "\n===============MySQL Handler===============\n" | ||
| # pytest -svx mindsdb/integrations/handlers/mysql_handler/ | ||
|
|
||
| # Currently requires a DB to be running. New testing system is being set up | ||
| # echo -e "\n===============PostgreSQL Handler===============\n" | ||
| # pytest -svx mindsdb/integrations/handlers/postgres_handler/ | ||
|
|
||
| echo -e "\n===============MariaDB Handler===============\n" | ||
| pytest -svx tests/handler_tests/test_mariadb_handler.py | ||
|
|
||
| echo -e "\n===============File Handler===============\n" | ||
| pytest -svx mindsdb/integrations/handlers/file_handler/ | ||
|
|
||
| echo -e "\n===============Home Rental Home Prices===============\n" | ||
| pytest -vx tests/integration_tests/flows/test_home_rental_prices_tutorial.py | ||
|
|
||
| echo -e "\n===============Forecast Quaterly House Sales===============\n" | ||
| pytest -vx tests/integration_tests/flows/test_forecast_quaterly_house_tutorial.py | ||
|
|
||
| echo -e "\n===============Predict Text Sentiment Wih Huggingface===============\n" | ||
| pytest -vx tests/integration_tests/flows/test_predict_text_sentiment_huggingface_tutorial.py | ||
|
|
||
| echo -e "\n===============Predict Text Sentiment Wih OpenAI===============\n" | ||
| pytest -vx tests/integration_tests/flows/test_predict_text_sentiment_openai_tutorial.py |
There was a problem hiding this comment.
Nitpick, and feel free to ignore it.
I prefer having the list of tests in a makefile, which I can run before submitting the commit.
Other than that, LGTM.
There was a problem hiding this comment.
Ive created #8957 to do this later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
test_on_push.yml: to be run whenever new code is pushed to a PRtest_on_deploy.yml: to be run whenever code is deployed to an environment (ideally these would be run against the deployed env - currently they are not). This is triggered by thebuild_deploy_devandbuild_deploy_stagingworkflows and not run directly itself.matrix_include.jsonto define the matrix of python versions/OSs to run tests on, for all testing jobs.