Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Snowflake Integration Docs with Tip to Install Git #9032

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

MinuraPunchihewa
Copy link
Collaborator

@MinuraPunchihewa MinuraPunchihewa commented Apr 5, 2024

Description

This PR adds a tip about the need to install Git in the Docker container before installing the dependencies for the Snowflake integration.

According to this comment, the official snowflake-sqlalchemy package will add support for SQLAlchemy 2 within this month. When that is done, the dependencies for the integration should be updated and this tip should be removed.

Partially fixes #9024

Type of change

  • 馃搫 This change requires a documentation update

Verification Process

To ensure the changes are working as expected:

  • Test Location: Specify the URL or path for testing.
  • Verification Steps: Outline the steps or queries needed to validate the change. Include any data, configurations, or actions required to reproduce or see the new functionality.

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB - N/A
  • I have appropriately commented on my code, especially in complex areas - N/A
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added - N/A

Copy link
Collaborator

@martyna-mindsdb martyna-mindsdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this info be added to all integrations?

@MinuraPunchihewa
Copy link
Collaborator Author

@martyna-mindsdb This is specific to the Snowflake integration.

@ZoranPandovski ZoranPandovski merged commit 3d203c5 into staging Apr 9, 2024
14 checks passed
@ZoranPandovski ZoranPandovski deleted the feature/update_snwflk_docs_dep_issue branch April 9, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Snowflake SQLAlchemy Dependency Issue
3 participants