New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zotero handler implementation #9084
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ElinaKapetanaki,
To continue our conversation on Slack here: is the pyzotero
package installed in your virtual environment?
Yes pyzotero is installed in my mindsdb-venv. |
@@ -0,0 +1,227 @@ | |||
import os | |||
import ast |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ElinaKapetanaki Please change this import to from mindsdb_sql.parser import ast
and try again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, will do. Is this the cause of the "not installed zotero handler" problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the handler has become unusable due to this error. Let me know if this fixes your issue. Try running the CREATE DATABASE
statement again with this fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!! The CREATE DATABASE
statement worked now! I will work on fixing a few things more and will update this pr.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The queries work!! Made quite a few changes to my code. I want to make it a bit cleaner and will update the pr with also some pictures of the functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ElinaKapetanaki Sounds great! Just mark the PR as ready for review whenever you are ready and I will take a look.
Description
This is the Zotero Handler Implementation that is focused -for now- at connecting to the Zotero library of a user and selecting his/her annotations, which is highlighted text on research material (either all annotations, a specific one or all annotations on a specific item, like on a specific book). More information about the implementation can be found on the README file of the handler.
Fixes #5637
Type of change
Verification Process
To ensure the changes are working as expected:
Checklist: