Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zotero handler implementation #9084

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ElinaKapetanaki
Copy link

Description

This is the Zotero Handler Implementation that is focused -for now- at connecting to the Zotero library of a user and selecting his/her annotations, which is highlighted text on research material (either all annotations, a specific one or all annotations on a specific item, like on a specific book). More information about the implementation can be found on the README file of the handler.

Fixes #5637

Type of change

  • ⚡ New feature (non-breaking change which adds functionality)

Verification Process

To ensure the changes are working as expected:

  • Test Location: Specify the URL or path for testing.
  • Verification Steps: Outline the steps or queries needed to validate the change. Include any data, configurations, or actions required to reproduce or see the new functionality.

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

Copy link
Collaborator

@MinuraPunchihewa MinuraPunchihewa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ElinaKapetanaki,
To continue our conversation on Slack here: is the pyzotero package installed in your virtual environment?

@ElinaKapetanaki
Copy link
Author

Yes pyzotero is installed in my mindsdb-venv.

@@ -0,0 +1,227 @@
import os
import ast
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ElinaKapetanaki Please change this import to from mindsdb_sql.parser import ast and try again?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, will do. Is this the cause of the "not installed zotero handler" problem?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the handler has become unusable due to this error. Let me know if this fixes your issue. Try running the CREATE DATABASE statement again with this fix.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!! The CREATE DATABASE statement worked now! I will work on fixing a few things more and will update this pr.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The queries work!! Made quite a few changes to my code. I want to make it a bit cleaner and will update the pr with also some pictures of the functionality.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ElinaKapetanaki Sounds great! Just mark the PR as ready for review whenever you are ready and I will take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Integration]: Zotero API Integration
2 participants