Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clickhouse improvments #9111

Merged
merged 15 commits into from Apr 29, 2024
Merged

Clickhouse improvments #9111

merged 15 commits into from Apr 29, 2024

Conversation

ZoranPandovski
Copy link
Member

@ZoranPandovski ZoranPandovski commented Apr 22, 2024

This PR verifies the CH Integration by:

  • Providing correct structure for README and Docs + troubleshooting guide
  • Adds unit tests and lints the code
  • Runs coveralls on CI push action
  • Removes unused QA file

Type of change

(Please delete options that are not relevant)

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ⚡ New feature (non-breaking change which adds functionality)
  • 📢 Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • 📄 This change has a documentation update

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

Signed-off-by: ZoranPandovski <zoran.pandovski@gmail.com>
@ZoranPandovski ZoranPandovski marked this pull request as draft April 22, 2024 13:47
@ZoranPandovski ZoranPandovski marked this pull request as ready for review April 23, 2024 13:57
# Conflicts:
#	.github/workflows/test_on_push.yml
Copy link
Collaborator

@MinuraPunchihewa MinuraPunchihewa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZoranPandovski This looks good to me. Are we going to be adding integration similar to the ones we have for Postgres?

@MinuraPunchihewa MinuraPunchihewa merged commit 7c26066 into staging Apr 29, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants