Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Integration]: Fireworks ai Integration #9131

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

bala-ceg
Copy link
Contributor

Description

Created Fireworks.ai ML Integration.

Fixes #9043

Type of change

  • ⚡ New feature (non-breaking change which adds functionality)

Verification Process

To ensure the changes are working as expected:

  • Test Location: Please refer Testing Screenshots section
  • Verification Steps: Created the integration engine, verified all the data queries successfully mentioned in README.md

Additional Media:

  • I have attached a brief loom video or screenshots showcasing the new functionality or change.

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

Testing Screenshots:

Screenshot 2024-04-24 at 11 16 01 PM Screenshot 2024-04-24 at 11 17 05 PM Screenshot 2024-04-24 at 11 17 55 PM Screenshot 2024-04-24 at 11 18 34 PM

@bala-ceg
Copy link
Contributor Author

@quest-bot loot #9043

@quest-bot quest-bot bot added the ⚔️ Quest Tracks quest-bot quests label Apr 24, 2024
Copy link

quest-bot bot commented Apr 24, 2024

Quest PR submitted! image Quest PR submitted!

@bala-ceg, you are attempting to solve the issue and loot this Quest. Will you be successful?


Questions? Check out the docs.

Copy link
Member

@ZoranPandovski ZoranPandovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Please check the above comments. Also, let's include unit tests and implement the embeddings https://readme.fireworks.ai/docs/querying-embeddings-models


Before proceeding, ensure the following prerequisites are met:

1. Install MindsDB [locally via Docker](https://docs.mindsdb.com/setup/self-hosted/docker) or use [MindsDB Cloud](https://cloud.mindsdb.com/).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove MindsDB Cloud as an option. For now keep Docker and Docker Desktop

Copy link
Contributor Author

@bala-ceg bala-ceg Apr 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it

@@ -0,0 +1,8 @@
supported_task = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

args = self.model_storage.json_get("args")


response = self.connection.ChatCompletion.create(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add try-except to handle possible exceptions

args = self.model_storage.json_get("args")


response = self.connection.ChatCompletion.create(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add try-except to handle possible exceptions

@@ -0,0 +1,8 @@
supported_task = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe change this to something more meaningfull too as: conversational or image mode?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚔️ Quest Tracks quest-bot quests
Projects
Status: to review
Development

Successfully merging this pull request may close these issues.

[Integration]: Fireworks ai Integration
2 participants