Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SQLDatabaseToolkit for Agent sql Skill #9132

Merged
merged 12 commits into from Apr 29, 2024
Merged

Conversation

tmichaeldb
Copy link
Contributor

Description

This PR updates agents to use Langchain's SQLDatabaseToolkit. We used to use this, but for some reason, we migrated to only using a single skill to query a database, rather than multiple useful skills in a toolkit.

Type of change

  • ⚡ New feature (non-breaking change which adds functionality)

Verification Process

To ensure the changes are working as expected:

  • Test Location: Specify the URL or path for testing.
  • Verification Steps: Create & use an agent locally with the Python SDK & sql skill

Additional Media:

  • I have attached a brief loom video or screenshots showcasing the new functionality or change.

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

Copy link
Contributor

@dusvyat dusvyat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see question above, otherwise looks good

@tmichaeldb tmichaeldb changed the base branch from retrieval-kb-migration to staging April 25, 2024 23:20
@tmichaeldb tmichaeldb merged commit 93529ef into staging Apr 29, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants