Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inference to cloud handler #9133

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Inference to cloud handler #9133

wants to merge 4 commits into from

Conversation

ZoranPandovski
Copy link
Member

Description

This PR changes the mindsdb inference handler as mindsdb cloud. The handler, README and docs are updated

Type of change

(Please delete options that are not relevant)

  • πŸ› Bug fix (non-breaking change which fixes an issue)
  • ⚑ New feature (non-breaking change which adds functionality)
  • πŸ“’ Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • πŸ“„ This change requires a documentation update

Additional Media:

Screenshot from 2024-04-25 16-49-08

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

docs/integrations/ai-engines/mindsdb_cloud.mdx Outdated Show resolved Hide resolved
docs/integrations/ai-engines/mindsdb_cloud.mdx Outdated Show resolved Hide resolved
mindsdb/integrations/handlers/mindsdb_cloud/README.md Outdated Show resolved Hide resolved
@@ -0,0 +1,9 @@
__title__ = 'MindsDB Cloud handler'
__package_name__ = 'mindsdb_cloud_handler'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we update the handler folder name to "mindsdb/integrations/handlers/mindsdb_cloud_handler (instead of "mindsdb_cloud")?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the name doesn't make any change since we are not releasing them. I just checked and it is the same in all handlers, so we may decide on keeping only the name without _handler

Copy link
Collaborator

@MinuraPunchihewa MinuraPunchihewa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZoranPandovski The existing changes look good, but I think we will have to update the unit tests in tests/unit/ml_handlers/test_mindsdb_inference.py as well?

@ZoranPandovski
Copy link
Member Author

Moving this to Draft as discussed

@ZoranPandovski ZoranPandovski marked this pull request as draft April 26, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants