Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

Add support for SPI Parameters #215

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

mirromutth
Copy link
Owner

@mirromutth mirromutth commented Nov 7, 2021

It resolves #164 .

Check list:

  • Rename dev.miku.r2dbc.mysql.Parameter into MySqlParameter to avoid user confusion and naming conflicts
  • Add io.r2dbc.spi.Parameter support in DefaultCodecs, just like r2dbc-postgresql
  • Add encoding type support in Codecs, e.g. LongCodec.canEncode(Long.class, doubleValue), LongCodec.encode(Long.class, doubleValue, context)
  • Add integration test cases for io.r2dbc.spi.Parameter

@mirromutth mirromutth added the enhancement New feature or request label Nov 7, 2021
@mirromutth mirromutth added this to the 0.9.0.RELEASE milestone Nov 7, 2021
@mirromutth mirromutth self-assigned this Nov 7, 2021
@linghengqian
Copy link

What's blocking this PR from being merged?

@ls-urs-keller
Copy link

ls-urs-keller commented Jan 23, 2023

@mirromutth I haven't checked the PRs before doing mine. I have a slightly different implementation in #249 the name "clash" is contained to the codec, so maybe renaming your class is not necessary.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for SPI Parameters
3 participants