-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LoRA: Extract small function #614
base: main
Are you sure you want to change the base?
Conversation
Maybe we should consider moving the function out of utils.py. It has becomed too large now, it might be better to create a new file named |
@mzbac Great suggestion. Initially, I tried placing the I will reassess the extent of changes needed to solve the circular dependency problem. The worst-case scenario would be creating a new file named |
The main reason for the circular dependency is the reliance on the I have now removed the logic of actively loading models within functions and instead accept an already loaded model. This can avoid issues with sequential dependencies. Meanwhile, it will be necessary to first load the model and then call the |
@madroidmaq sorry for the delay! I think we can merge this. But could you first rebase to resolve conflicts? |
@awni It's DONE. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Extract the
load_with_lora
function for easy use in other files.