[stdlib] add b64decode #2364
[stdlib] add b64decode #2364
Conversation
mikowals
force-pushed
the
base64-decode
branch
4 times, most recently
from
5e7b1c5
to
5ceb47c
Compare
Signed-off-by: Michael Kowalski <1331470+mikowals@users.noreply.github.com>
| from testing import assert_equal | ||
|
|
||
|
|
||
| def test_b64encode(): | ||
| print("== test_b64encode") |
There was a problem hiding this comment.
Suggestion Drop the print here and in the decode function below. The print(...) is only needed in FileCheck-style tests so the tool has something to latch onto for its regex-matching internally.
There was a problem hiding this comment.
I went ahead and removed these prints when I imported the PR internally since it was trivial to change, so don't feel the need to do anything. 😄
JoeLoser
added
imported-internally
|
✅🟣 This contribution has been merged 🟣✅ Hey @mikowals, Thanks so much for the contribution! 🎉 We're moving to a new infrastructure for merging contributions to Mojo (we're using a tool called Copybara), and your contribution has now been merged into our internal copy of the Mojo Standard Library. I've added the "merged-internally" label on this PR. The changes in this PR will appear here in the mojo repo nightly branch when we do our next outbound synchronization at the time that the next Mojo nightly is released. That should happen on Monday (tomorrow). Please let me know if you have any questions or concerns. |
[External] [stdlib] add b64decode Followed the decode algorithm from the same paper used for `b64encode`. The Llama3 `tokenizer.model` stores the tokens with base64 encoding so demand for this may increase. 😃 ORIGINAL_AUTHOR=Michael Kowalski <1331470+mikowals@users.noreply.github.com> PUBLIC_PR_LINK=modularml#2364 --------- Co-authored-by: Michael Kowalski <1331470+mikowals@users.noreply.github.com> Closes modularml#2364 MODULAR_ORIG_COMMIT_REV_ID: de91cca69272570a52fcbf28a5c51c8d7fe75364
[External] [stdlib] add b64decode Followed the decode algorithm from the same paper used for `b64encode`. The Llama3 `tokenizer.model` stores the tokens with base64 encoding so demand for this may increase. 😃 ORIGINAL_AUTHOR=Michael Kowalski <1331470+mikowals@users.noreply.github.com> PUBLIC_PR_LINK=#2364 --------- Co-authored-by: Michael Kowalski <1331470+mikowals@users.noreply.github.com> Closes #2364 MODULAR_ORIG_COMMIT_REV_ID: de91cca69272570a52fcbf28a5c51c8d7fe75364
|
Closing as this got merged into the latest |
[External] [stdlib] add b64decode Followed the decode algorithm from the same paper used for `b64encode`. The Llama3 `tokenizer.model` stores the tokens with base64 encoding so demand for this may increase. 😃 ORIGINAL_AUTHOR=Michael Kowalski <1331470+mikowals@users.noreply.github.com> PUBLIC_PR_LINK=modularml#2364 --------- Co-authored-by: Michael Kowalski <1331470+mikowals@users.noreply.github.com> Closes modularml#2364 MODULAR_ORIG_COMMIT_REV_ID: de91cca69272570a52fcbf28a5c51c8d7fe75364
Followed the decode algorithm from the same paper used for
b64encode.The Llama3
tokenizer.modelstores the tokens with base64 encoding so demand for this may increase. 😃