[mojo-stdlib] Add List.count(value) method
#2406
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StandinKP
changed the title
JoeLoser
reviewed
Apr 27, 2024
JoeLoser
changed the title
List.count(value) method
|
@JoeLoser are we having any ticket to track adding the conditional conformance? Is that something we can work on or is it going to be internal development? |
|
@StandinKP it's something that must be done internally. There is an issue here: #1876 to follow the progress if you want. It seems that it's not going to be available in the short term |
JoeLoser
approved these changes
Apr 29, 2024
JoeLoser
reviewed
Apr 30, 2024
Signed-off-by: Kaushal Phulgirkar <kaushalpp01@gmail.com>
Signed-off-by: Kaushal Phulgirkar <kaushalpp01@gmail.com>
Signed-off-by: Kaushal Phulgirkar <kaushalpp01@gmail.com>
Signed-off-by: Kaushal Phulgirkar <kaushalpp01@gmail.com>
Signed-off-by: Kaushal Phulgirkar <kaushalpp01@gmail.com>
StandinKP
force-pushed
the
add_count_fn_to_list
branch
from
e276630
to
ac2d8bf
Compare
JoeLoser
added
the
imported-internally
JoeLoser
pushed a commit
that referenced
this pull request
May 3, 2024
[External] [mojo-stdlib] Add `List.count(value)` method Add `List.count(value)` method to count the number of occurrences of a value in the `List`. Fixes #2263 --------- Co-authored-by: Kaushal Phulgirkar <kaushalpp01@gmail.com> Closes #2406 MODULAR_ORIG_COMMIT_REV_ID: e9e9be6db11d56f951e94daf22fd0ff8520615fa
|
This landed internally and got pushed out already - see c37a3ec. Closing this PR. Thanks again for the contribution!! 🎉 |
JoeLoser
added
merged-internally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
List.count(value)method to count the number of occurrences of a value in theList.Fixes #2263