Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stdlib] String comparisons implemented #2409

Closed
wants to merge 13 commits into from
Closed

[stdlib] String comparisons implemented #2409

wants to merge 13 commits into from

Commits on Apr 29, 2024

  1. [stdlib] Implemented __lt__, __le__, __gt__, & __ge__ for String, and… 

    … added tests.

Signed-off-by: Simon Hellsten <simonhellsten@hotmail.com>
    @siitron
    siitron committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    ccbe327 View commit details
    Browse the repository at this point in the history

  2. [stdlib] Whitespace and formatting fix. 

    Signed-off-by: Simon Hellsten <simonhellsten@hotmail.com>
    @siitron
    siitron committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    3a0146b View commit details
    Browse the repository at this point in the history

  3. [stdlib] Removed an accidental variable redefiniton in test_compariso… 

    …n_operators() for String.

Signed-off-by: Simon Hellsten <simonhellsten@hotmail.com>
    @siitron
    siitron committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    d84deef View commit details
    Browse the repository at this point in the history

  4. [stdlib] small change to String's test_comparison_operators() 

    Signed-off-by: Simon Hellsten <simonhellsten@hotmail.com>
    @siitron
    siitron committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    69c1d12 View commit details
    Browse the repository at this point in the history

  5. [stdlib] Implemented __lt__, __le__, __gt__, & __ge__ for StringLiter… 

    …al (+tests)

Signed-off-by: Simon Hellsten <simonhellsten@hotmail.com>
    @siitron
    siitron committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    c9d58da View commit details
    Browse the repository at this point in the history

  6. Merge branch 'modularml:nightly' into nightly

    @siitron
    siitron committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    9dea5b9 View commit details
    Browse the repository at this point in the history

  7. [stdlib] Replaced invalid usages of math.min in string.mojo and strin… 

    …g_literal.mojo with if/else-statements. Also fixed the string comparison tests to make them look better when formatted correctly.

Signed-off-by: Simon Hellsten <simonhellsten@hotmail.com>
    @siitron
    siitron committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    3439ea3 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Merge branch 'modularml:nightly' into nightly

    @siitron
    siitron committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    3295806 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2024

  1. Merge branch 'modularml:nightly' into nightly

    @siitron
    siitron committed May 4, 2024
    Configuration menu
    Copy the full SHA
    47701d8 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Merge branch 'modularml:nightly' into nightly

    @siitron
    siitron committed May 7, 2024
    Configuration menu
    Copy the full SHA
    b17a855 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Merge branch 'modularml:nightly' into nightly

    @siitron
    siitron committed May 8, 2024
    Configuration menu
    Copy the full SHA
    13cb73b View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Merge branch 'modularml:nightly' into nightly

    @siitron
    siitron committed May 9, 2024
    Configuration menu
    Copy the full SHA
    2b73124 View commit details
    Browse the repository at this point in the history

  2. [stdlib] Replaced ._as_ptr() with .unsafe_ptr() in String and StringL… 

    …iteral's __lt__-methods. Also updated the tests to use the dunder methods directly (instead of their operators).

Signed-off-by: Simon Hellsten <simonhellsten@hotmail.com>
    @siitron
    siitron committed May 9, 2024
    Configuration menu
    Copy the full SHA
    5b03ae8 View commit details
    Browse the repository at this point in the history