New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add fish
version of the set-up command
#2423
Conversation
Thanks for this contribution @vthemelis!😄 This looks good to me, but I've requested @scottamain or @arthurevans on our docs team to give this a look as well as they know more about that area than me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome thank you!
d765e7b
to
0a8ff9f
Compare
Hi @vthemelis, before we can merge this PR our tooling requires that this baseline commit is present in the history of this branch. Could you rebase your branch onto the latest That should be as simple as: # Update your local copy of nightly
$ git checkout nightly
$ git pull
# Rebase your branch to incorporate latest nightly commits
$ git checkout fish-get-started
$ git rebase nightly
# Push your updated branch to this PR
$ git push --force Thanks you again for contributing this, and apologies for this additional work! This should be a one-time thing, as any future PRs will likely include that baseline commit after you've updated your nightly branch once. |
0a8ff9f
to
9bf708e
Compare
Signed-off-by: Vasilis Themelis <vdthemelis@gmail.com>
9bf708e
to
7ac5cfb
Compare
✅🟣 This contribution has been merged 🟣✅ Thanks for this 🐟 y contribution 😉 @vthemelis! 😄 Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the We use Copybara to merge external contributions, click here to learn more. |
[External] [docs] Add `fish` version of the set-up command Co-authored-by: Vasilis Themelis <vdthemelis@gmail.com> Closes #2423 MODULAR_ORIG_COMMIT_REV_ID: 376a924f470e84b9f1775382ee452386fbe3e281
[External] [docs] Add `fish` version of the set-up command Co-authored-by: Vasilis Themelis <vdthemelis@gmail.com> Closes modularml#2423 MODULAR_ORIG_COMMIT_REV_ID: 376a924f470e84b9f1775382ee452386fbe3e281 Signed-off-by: Manuel Saelices <msaelices@gmail.com>
No description provided.