Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add fish version of the set-up command #2423

Closed
wants to merge 1 commit into from

Conversation

vthemelis
Copy link

No description provided.

@ConnorGray
Copy link
Collaborator

Thanks for this contribution @vthemelis!😄

This looks good to me, but I've requested @scottamain or @arthurevans on our docs team to give this a look as well as they know more about that area than me.

@ConnorGray ConnorGray self-requested a review May 1, 2024 21:12
Copy link
Collaborator

@scottamain scottamain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thank you!

@ConnorGray
Copy link
Collaborator

ConnorGray commented May 2, 2024

Hi @vthemelis, before we can merge this PR our tooling requires that this baseline commit is present in the history of this branch.

Could you rebase your branch onto the latest nightly branch and then force push it to update this PR?

That should be as simple as:

# Update your local copy of nightly
$ git checkout nightly
$ git pull

# Rebase your branch to incorporate latest nightly commits
$ git checkout fish-get-started
$ git rebase nightly

# Push your updated branch to this PR
$ git push --force

Thanks you again for contributing this, and apologies for this additional work! This should be a one-time thing, as any future PRs will likely include that baseline commit after you've updated your nightly branch once.

@vthemelis vthemelis changed the base branch from main to nightly May 3, 2024 16:38
@vthemelis vthemelis requested a review from a team as a code owner May 3, 2024 16:38
Signed-off-by: Vasilis Themelis <vdthemelis@gmail.com>
@ConnorGray ConnorGray added imported-internally Signals that a given pull request has been imported internally. merged-internally Indicates that this pull request has been merged internally labels May 3, 2024
@ConnorGray
Copy link
Collaborator

✅🟣 This contribution has been merged 🟣✅

Thanks for this 🐟 y contribution 😉 @vthemelis! 😄

Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours.

We use Copybara to merge external contributions, click here to learn more.

@ConnorGray ConnorGray closed this May 3, 2024
JoeLoser pushed a commit that referenced this pull request May 3, 2024
[External] [docs] Add `fish` version of the set-up command

Co-authored-by: Vasilis Themelis <vdthemelis@gmail.com>
Closes #2423
MODULAR_ORIG_COMMIT_REV_ID: 376a924f470e84b9f1775382ee452386fbe3e281
msaelices pushed a commit to msaelices/mojo that referenced this pull request May 5, 2024
[External] [docs] Add `fish` version of the set-up command

Co-authored-by: Vasilis Themelis <vdthemelis@gmail.com>
Closes modularml#2423
MODULAR_ORIG_COMMIT_REV_ID: 376a924f470e84b9f1775382ee452386fbe3e281

Signed-off-by: Manuel Saelices <msaelices@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imported-internally Signals that a given pull request has been imported internally. merged-internally Indicates that this pull request has been merged internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants