[stdlib] Implement mkdir and rmdir #2430
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artemio Garza Reyna <artemiogr97@gmail.com>
artemiogr97
changed the title
artemiogr97
force-pushed
the
mkdir_and_rmdir
branch
from
130747e
to
f2b9e2c
Compare
Signed-off-by: Artemio Garza Reyna <artemiogr97@gmail.com>
artemiogr97
force-pushed
the
mkdir_and_rmdir
branch
from
f2b9e2c
to
7e80185
Compare
abduld
reviewed
Apr 30, 2024
Signed-off-by: Artemio Garza Reyna <artemiogr97@gmail.com>
abduld
approved these changes
May 2, 2024
JoeLoser
added
the
imported-internally
|
Quick update here: this is still working on landing internally. On CI, I'm seeing some tests fail related to your change. On Graviton, some |
|
✅🟣 This contribution has been merged 🟣✅ Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours. We use Copybara to merge external contributions, click here to learn more. |
modularbot
added
the
merged-internally
JoeLoser
pushed a commit
that referenced
this pull request
May 11, 2024
[External] [stdlib] Implement `mkdir` and `rmdir` Add functionality to the `os` module for creating and removing directories via `mkdir` and `rmdir`. Signed-off-by: Artemio Garza Reyna <artemiogr97@gmail.com> Co-authored-by: Artemio Garza Reyna <artemiogr97@gmail.com> Closes #2430 MODULAR_ORIG_COMMIT_REV_ID: 8571848227dfd72f1672699a227e21354d5cf3e1
|
Landed in today's nightly: #2615. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artemio Garza Reyna artemiogr97@gmail.com