[stdlib] Constrain simd.bool() to size == 1
#2502
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, I wish they were called |
|
i was thinking the same thing, but they can be separate to avoid bitwise ambiguity |
|
Just a quick update here: this has been approved internally, but I need to go fix up more uses internally this breaks before we can land it. |
JoeLoser
approved these changes
May 9, 2024
JoeLoser
added
the
imported-internally
|
I was about to try adding edit: I did it anyway, but can't open the pr till I get online... |
|
I thought there was something else that should get done before |
helehex
force-pushed
the
stdlib/constrain-simd-bool
branch
from
a2d125b
to
4ceb858
Compare
Signed-off-by: Max Brylski <helehex@gmail.com>
helehex
force-pushed
the
stdlib/constrain-simd-bool
branch
from
4ceb858
to
bb3de08
Compare
modularbot
pushed a commit
that referenced
this pull request
May 16, 2024
[External] [stdlib] Add builtin `any()`/`all()` functions Adds builtin functions for testing if there are truthy elements in `List`, `Set`, `SIMD`. Should change to check iterators eventually. Also mentioned [here](#2502) --------- Co-authored-by: Helehex <Helehex@gmail.com> Closes #2600 MODULAR_ORIG_COMMIT_REV_ID: 894768635c30c41fa359a69e5110b60adce735f8
lsh
pushed a commit
to lsh/mojo
that referenced
this pull request
May 17, 2024
[External] [stdlib] Add builtin `any()`/`all()` functions Adds builtin functions for testing if there are truthy elements in `List`, `Set`, `SIMD`. Should change to check iterators eventually. Also mentioned [here](modularml#2502) --------- Co-authored-by: Helehex <Helehex@gmail.com> Closes modularml#2600 MODULAR_ORIG_COMMIT_REV_ID: 894768635c30c41fa359a69e5110b60adce735f8 Signed-off-by: Lukas Hermann <lukashermann28@gmail.com>
|
✅🟣 This contribution has been merged 🟣✅ Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours. We use Copybara to merge external contributions, click here to learn more. |
modularbot
added
merged-internally
|
Landed in a31a0e6! Thank you for your contribution 🎉 |
msaelices
pushed a commit
to msaelices/mojo
that referenced
this pull request
May 18, 2024
[External] [stdlib] Add builtin `any()`/`all()` functions Adds builtin functions for testing if there are truthy elements in `List`, `Set`, `SIMD`. Should change to check iterators eventually. Also mentioned [here](modularml#2502) --------- Co-authored-by: Helehex <Helehex@gmail.com> Closes modularml#2600 MODULAR_ORIG_COMMIT_REV_ID: 894768635c30c41fa359a69e5110b60adce735f8
msaelices
pushed a commit
to msaelices/mojo
that referenced
this pull request
May 18, 2024
[External] [stdlib] Constrain `simd.bool()` to `size == 1` Use explicit `reduce_or()`/`reduce_and()` instead See modularml#2412. Co-authored-by: Helehex <Helehex@gmail.com> Closes modularml#2502 MODULAR_ORIG_COMMIT_REV_ID: b0e954912430469a9a60fb73ea46a4e7edf96964
modularbot
pushed a commit
that referenced
this pull request
May 22, 2024
…bitwise operations (#40348) [External] [stdlib] Change `SIMD.reduce_and()`/`SIMD.reduce_or()` to bitwise operations changes the behavior of simd `reduce_and()`/`reduce_or()` to be bitwise operations. Theres a few things that are related to this: [builtin `any()`/`all()` functions](#2600) [constrain simd bool to size=1](#2502) Co-authored-by: Helehex <Helehex@gmail.com> Closes #2671 MODULAR_ORIG_COMMIT_REV_ID: 1ab75b0817529420ea8dd4baf3014ea97dc162ad
martinvuyk
pushed a commit
to martinvuyk/mojo
that referenced
this pull request
May 24, 2024
[External] [stdlib] Add builtin `any()`/`all()` functions Adds builtin functions for testing if there are truthy elements in `List`, `Set`, `SIMD`. Should change to check iterators eventually. Also mentioned [here](modularml#2502) --------- Co-authored-by: Helehex <Helehex@gmail.com> Closes modularml#2600 MODULAR_ORIG_COMMIT_REV_ID: 894768635c30c41fa359a69e5110b60adce735f8
martinvuyk
pushed a commit
to martinvuyk/mojo
that referenced
this pull request
May 24, 2024
[External] [stdlib] Constrain `simd.bool()` to `size == 1` Use explicit `reduce_or()`/`reduce_and()` instead See modularml#2412. Co-authored-by: Helehex <Helehex@gmail.com> Closes modularml#2502 MODULAR_ORIG_COMMIT_REV_ID: b0e954912430469a9a60fb73ea46a4e7edf96964
martinvuyk
pushed a commit
to martinvuyk/mojo
that referenced
this pull request
May 24, 2024
…bitwise operations (#40348) [External] [stdlib] Change `SIMD.reduce_and()`/`SIMD.reduce_or()` to bitwise operations changes the behavior of simd `reduce_and()`/`reduce_or()` to be bitwise operations. Theres a few things that are related to this: [builtin `any()`/`all()` functions](modularml#2600) [constrain simd bool to size=1](modularml#2502) Co-authored-by: Helehex <Helehex@gmail.com> Closes modularml#2671 MODULAR_ORIG_COMMIT_REV_ID: 1ab75b0817529420ea8dd4baf3014ea97dc162ad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use explicit
reduce_or()/reduce_and()insteadsee #2412