fix: error handling for file operations

[trishan9]

The code for the function read_tsv and read_prefs doesn't have explicit error handling for file operations. This modification will catch any File error operations, or IOError exceptions that occur when trying to open or read the file, and print an error message.

[sumanashrestha]

could you also also do the same for pref file as well ?

[trishan9]

could you also also do the same for pref file as well ?

sure!

[trishan9]

please review, I have updated my PR accordingly! @sumanashrestha @horrormyth

[horrormyth]

Great stuff, few minor comments and test would be great, otherwise looking good 💪 🎖️

[horrormyth]

I think we can just use the logger as follows. No need to use the logging module and basiconfig, we can set the default log level if needed in the future.

from logging import getLogger 
logger = getLogger(__name__) `
logger.info/error("Lovely message")

[horrormyth]

The message does not need to mention "Error" as the logline itself is an error, so
logger.error(f"File '{file_path}' not found.") would be enough, and the same for others.

[horrormyth]

Let's make sure that test is covered and/or added later on

[rajan-poudel]

👏👏

[sapradhan]

The original code would exit when any of the error occurs and print stack trace.

26 added lines later, it still does essentially the same thing but with some extra error message which would have been fairly obvious with the exception name.

I am generally for proper error handling but just stating my observation.

[horrormyth]

The original code would exit when any of the error occurs and print stack trace.

26 added lines later, it still does essentially the same thing but with some extra error message which would have been fairly obvious with the exception name.

I am generally for proper error handling but just stating my observation.

Disagreement:
The client/user is not capable of dissecting the exception traceback, those are only for developers who can understand them. So, in any client use case, throwing exceptions to them is a bad idea. The user should be informed nicely about what went wrong regardless of how miserably the system failed. Here, the message is nicely written, and the user will know what went wrong.

[sumanashrestha]

please resolve the conflicts, so that this can be merged