Fixed: output directory generation not working as expected when --output is passed a directory name instead of filename #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…into fix/output_location
sapradhan
reviewed
Apr 24, 2024
|
@sumanashrestha , changes are done to meet all the requirements you mentioned in the PR discussion. For writing test, I think, it would be better to write modular tests but right now main logic is executed outside of any function. However, for now it is properly tested manually and is ready to merge. |
sapradhan
reviewed
Apr 25, 2024
| if(basename): | ||
| return basename | ||
| else: | ||
| return DEFAULT_OUTOUT_FILENAME |
There was a problem hiding this comment.
typo DEFAULT_OUTPUT_FILENAME
sapradhan
reviewed
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39
The solved problem:
-oor--outputwas not passed or whenfilenamewas passed from CLI, it was working wellIt is solved now
Changes done
The fixed code now uses
os.pathmodule to extractdirnameandfilenamefrom the provided args and uses them accordingly.