OIDC admin credentials #1389
Merged
OIDC admin credentials #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6898b4f. # Conflicts: # driver-sync/src/test/functional/com/mongodb/client/unified/Entities.java
jyemin
reviewed
May 15, 2024
jyemin
reviewed
May 15, 2024
driver-sync/src/test/functional/com/mongodb/client/unified/Entities.java
Show resolved
Hide resolved
jyemin
reviewed
May 15, 2024
katcharov
commented
May 22, 2024
| @@ -234,6 +234,8 @@ public void test2p4InvalidClientConfigurationWithCallback() { | |||
|
|
|||
| @Test | |||
| public void test2p5InvalidAllowedHosts() { | |||
| assumeTestEnvironment(); | |||
There was a problem hiding this comment.
There is no requirement to run this test in a non-"test" environment; disabled to prevent running on GCP. Tests passing here.
jyemin
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes failing tests: reverts removal of admin credentials for OIDC tests, and corrects a typo in a validation test.
JAVA-5450