-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(NODE-6201): cursor to use fetchBatch when current batch is empty #4093
Merged
+230
−276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
nbbeeken
force-pushed
the
refactor-cursor-nextBatch
branch
2 times, most recently
from
April 30, 2024 22:53
f39ebac
to
ff12d3d
Compare
nbbeeken
commented
May 1, 2024
nbbeeken
force-pushed
the
refactor-cursor-nextBatch
branch
2 times, most recently
from
May 16, 2024 14:52
29beee7
to
092ee7b
Compare
nbbeeken
force-pushed
the
refactor-cursor-nextBatch
branch
from
June 3, 2024 19:25
092ee7b
to
8614df3
Compare
W-A-James
added
the
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
label
Jun 4, 2024
nbbeeken
changed the title
refactor: cursor to use fetchBatch function when current batch is empty
refactor(NODE-6201): cursor to use fetchBatch function when current batch is empty
Jun 4, 2024
W-A-James
reviewed
Jun 5, 2024
W-A-James
added
Team Review
Needs review from team
and removed
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
labels
Jun 5, 2024
W-A-James
previously approved these changes
Jun 5, 2024
baileympearson
requested changes
Jun 5, 2024
nbbeeken
changed the title
refactor(NODE-6201): cursor to use fetchBatch function when current batch is empty
refactor(NODE-6201): cursor to use fetchBatch when current batch is empty
Jun 5, 2024
baileympearson
previously approved these changes
Jun 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One optional comment.
W-A-James
previously approved these changes
Jun 7, 2024
baileympearson
approved these changes
Jun 7, 2024
W-A-James
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
next
into cursor and rename to fetchBatchIs there new documentation needed for these changes?
No
What is the motivation for this change?
The
next
floating function owned too many details of the implementation of each cursor API, tryNext and next now do a small amount more lifting and we have a fetchBatch method that is focused on obtaining the next batch either with the init command or with a getMore.Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript