Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: signal effects #1043

Merged
merged 3 commits into from
May 16, 2024
Merged

Conversation

aarthificial
Copy link
Contributor

Closes: #945

Copy link
Contributor

@hhenrichsen hhenrichsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are couple comma and wording changes I noticed while reading it out loud, but overall looks great.

packages/docs/docs/getting-started/effects.mdx Outdated Show resolved Hide resolved
packages/docs/docs/getting-started/effects.mdx Outdated Show resolved Hide resolved
packages/docs/docs/getting-started/effects.mdx Outdated Show resolved Hide resolved
packages/docs/docs/getting-started/effects.mdx Outdated Show resolved Hide resolved
packages/docs/docs/getting-started/effects.mdx Outdated Show resolved Hide resolved
packages/docs/docs/getting-started/effects.mdx Outdated Show resolved Hide resolved
packages/docs/docs/getting-started/effects.mdx Outdated Show resolved Hide resolved
packages/docs/docs/getting-started/effects.mdx Outdated Show resolved Hide resolved
packages/docs/docs/getting-started/effects.mdx Outdated Show resolved Hide resolved
packages/docs/docs/getting-started/effects.mdx Outdated Show resolved Hide resolved
@aarthificial aarthificial merged commit 00fa967 into motion-canvas:main May 16, 2024
9 checks passed
@aarthificial aarthificial deleted the signal-effects branch May 16, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce Signal Effects
2 participants