Solve issue #22 for Pytorch versions >= 1.3.0 #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@msamogh could you please check this pull request and merge the branch? your project is good, but that issue stops me from using it |
afiaka87
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just commented one line in
nonechucks/dataloader.pysince it raised an exception with PyTorch >=1.3.0. Commenting this line seems to make the program work as expected.I ran a few experiments to find out why that line was necessary in the code, but I did not find anything problematic with that new version so I did not do any additional changes. Please tell me if you remember why you wrote this specific line in your code.
I also wrote a few tests. It's not a lot but I added them anyway to the
tests/folder.I ran all my experiments with PyTorch 1.5.0.