Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS: add describing emoji to all resources #81

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

CHBaker
Copy link

@CHBaker CHBaker commented Oct 8, 2017

Add emoji's where there were none,

  • Computer describes online course
  • Floppy describes code/git repos
  • Check for license
  • Wrench for service

etc.

Copy link
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it

@mr-mig
Copy link
Member

mr-mig commented Oct 13, 2017

I would kindly ask you to update the CONTRIBUTING.md with the guidelines for the emoji you have added (in the scope of this PR). 🙏

@CHBaker
Copy link
Author

CHBaker commented Oct 13, 2017 via email

@CHBaker
Copy link
Author

CHBaker commented Oct 18, 2017

@mr-mig can you clarify what you mean by, update the CONTRIBUTING.md with the guidelines for the emoji you have added?

@eamanu
Copy link
Contributor

eamanu commented Oct 18, 2017

@CHBaker I think that he want that you make a description about 'why' you select a emoji for each item. And this will be a guidelines for future contributions

@CHBaker
Copy link
Author

CHBaker commented Oct 18, 2017

I see, okay

@mr-mig
Copy link
Member

mr-mig commented Oct 25, 2017

Yeah, sorry for not been clear enough @CHBaker
I just wanna you to add the list of emojis you use to the CONTRIBUTING.md

It has some emojis alongside the list of "resource types" those emojis should be used for.
Just do the same thing with emojis you've added to the README.md in the initial PR.

Cheat Sheet for using emoji's to describe resources
@CHBaker
Copy link
Author

CHBaker commented Nov 6, 2017

Alright, I added the descriptions, let me know what you guys think, if any other changes should be made, or different phrasing

Better grammar and wording
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants