Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui][AvatarGroup] deprecate
componentsProps
for v6 #42122[material-ui][AvatarGroup] deprecate
componentsProps
for v6 #42122Changes from 6 commits
97dbf29
1f4d3d1
63f3ea4
288c58b
9174052
8b95211
39c3f40
309d58b
596cd4a
378858a
c997f46
5737aed
7b3d31a
30184a0
7d0c9fd
1ba9d58
4ea5878
de5c77b
fff3076
88703af
5c395e1
e8a1512
a4fdeb4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we implement the
additionalAvatar
slot properly? I thinksurplus
is a better name. This would mean:slots.surplus
andslotProps.surplus
useSlot
hookWhat do you think @lhilgert9?
@mnajdova tagging you as the owner of the Avatar component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds logical to me and would also ensure uniformity for all components and offer the end user more customization options.👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's implement it 🙌🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DiegoAndai I have added
surplus
asslots
andslotProps
prop. I have markedslotProps.additionalAvatar
as@deprecated
. I also modified the codemod to changeadditionalAvatar
tosurplus
. I just didn't know which tests you wanted to implement. If you tell me which ones we need there, I'll implement them too.