-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring MTA code - Part 1 #3340
Open
TracerDS
wants to merge
9
commits into
multitheftauto:master
Choose a base branch
from
TracerDS:140324_Refactoring_Part-1
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refactoring MTA code - Part 1 #3340
TracerDS
wants to merge
9
commits into
multitheftauto:master
from
TracerDS:140324_Refactoring_Part-1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Did you manage to compile these changes successfully on any platform, or have you just done a find and replace then submitted a PR? |
Its compiling but Im having some memory violation issues |
TracerDS
force-pushed
the
140324_Refactoring_Part-1
branch
2 times, most recently
from
May 28, 2024 08:57
22f9930
to
97025ef
Compare
TracerDS
force-pushed
the
140324_Refactoring_Part-1
branch
from
May 28, 2024 08:57
97025ef
to
2fdcddc
Compare
I hope that this will fix errors in arm builds ;_;
Replaced `FLOAT` with `float`; useless alias
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently most mta's code uses generic
unsigned
types which are platform dependent.cstdint
header however is (should be) platform independent.This PR focuses on that irregularity and replaces all
unsigned
(and somewherelong long
) into thecstdint
types.MTA's source code is huuge. So there is a gigantic number of changes
Splitting the PR into multiple PR's with the same changes would bring too much troubles