-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Engine pool functions #3346
Engine pool functions #3346
Conversation
Please resolve conflicts |
done |
There's still a conflict in |
It's a new one. Resolved |
This is quite a big change, and it appears no one's interested in reviewing it. Despite that, you did many passes over it yourself (kept improving upon it) and it's known your skills resulted in your own write access as well as not really producing bugs in other contributions. That's my reasoning for just going ahead with merge and saying it can be tested in nightly instead. Thanks! |
After #3330 and #3275
The set function is implemented for building pool only.