Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engine pool functions #3346

Merged

Conversation

TheNormalnij
Copy link
Contributor

After #3330 and #3275

The set function is implemented for building pool only.

number engineGetPoolCapacity(enum pool)
number engineGetPoolDefaultCapacity(enum pool)
number engineGetPoolUsedCapacity(enum pool)
boolean engineSetPoolCapacity('building', number newSize)

@TheNormalnij TheNormalnij changed the title The normalnij/engine set pool size Engine pool functions Mar 18, 2024
@Dutchman101
Copy link
Member

Please resolve conflicts
@TheNormalnij

@TheNormalnij TheNormalnij marked this pull request as ready for review April 29, 2024 20:01
@TheNormalnij
Copy link
Contributor Author

Please resolve conflicts
@TheNormalnij

done

@Dutchman101
Copy link
Member

@TheNormalnij

done

There's still a conflict in mods/deathmatch/logic/CClientBuilding.h

@TheNormalnij
Copy link
Contributor Author

There's still a conflict in mods/deathmatch/logic/CClientBuilding.h

It's a new one. Resolved

@Dutchman101
Copy link
Member

This is quite a big change, and it appears no one's interested in reviewing it. Despite that, you did many passes over it yourself (kept improving upon it) and it's known your skills resulted in your own write access as well as not really producing bugs in other contributions. That's my reasoning for just going ahead with merge and saying it can be tested in nightly instead.

Thanks!

@Dutchman101 Dutchman101 merged commit bdf1221 into multitheftauto:master May 27, 2024
6 checks passed
MTABot pushed a commit that referenced this pull request May 27, 2024
@TheNormalnij TheNormalnij deleted the TheNormalnij/engine_set_pool_size branch May 28, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants