Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LOD support for buildings #3371

Merged
merged 10 commits into from
May 25, 2024
Merged

Add LOD support for buildings #3371

merged 10 commits into from
May 25, 2024

Conversation

TheNormalnij
Copy link
Contributor

Added LOD support for buildings.
Updated functions:

@TheNormalnij TheNormalnij added the enhancement New feature or request label Apr 21, 2024
znvjder
znvjder suggested changes Apr 21, 2024
View reviewed changes
Copy link
Contributor

@znvjder znvjder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some typographical error.

Client/mods/deathmatch/logic/CClientBuilding.h Outdated Show resolved Hide resolved
Client/mods/deathmatch/logic/CClientBuilding.cpp Outdated Show resolved Hide resolved
Client/mods/deathmatch/logic/CClientBuilding.cpp Outdated Show resolved Hide resolved
Client/mods/deathmatch/logic/CClientBuilding.cpp Outdated Show resolved Hide resolved
Nico8340
Nico8340 approved these changes Apr 21, 2024
View reviewed changes
Copy link
Contributor

@Nico8340 Nico8340 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

tederis
tederis reviewed Apr 22, 2024
View reviewed changes
Client/game_sa/CBuildingSA.cpp Outdated Show resolved Hide resolved
Client/game_sa/CBuildingSA.cpp Outdated Show resolved Hide resolved
Client/game_sa/CBuildingSA.cpp Show resolved Hide resolved
Client/mods/deathmatch/logic/CClientBuilding.cpp Outdated Show resolved Hide resolved
Client/mods/deathmatch/logic/CClientBuilding.cpp Outdated Show resolved Hide resolved
Client/mods/deathmatch/logic/CClientBuilding.h Outdated Show resolved Hide resolved
Client/mods/deathmatch/logic/lua/CLuaFunctionParseHelpers.cpp Outdated Show resolved Hide resolved
@TheNormalnij TheNormalnij marked this pull request as ready for review April 22, 2024 18:42
@TheNormalnij TheNormalnij marked this pull request as draft April 22, 2024 18:42
@TheNormalnij TheNormalnij marked this pull request as ready for review April 23, 2024 21:46
@Dutchman101
Copy link
Member

"GeBuildingEntity": is this a typo or intended? "Ge"
@TheNormalnij

@TheNormalnij
Copy link
Contributor Author

"GeBuildingEntity": is this a typo or intended? "Ge"

yeah, fixed

@Dutchman101 Dutchman101 merged commit 77ab3e6 into multitheftauto:master May 25, 2024
6 checks passed
@Dutchman101
Copy link
Member

@TheNormalnij thanks, please reflect it on the wiki

MTABot pushed a commit that referenced this pull request May 25, 2024
@github-actions
Synchronize changes from 1.6 master branch [ci skip]
cf29919 
77ab3e6 Add LOD support for buildings (#3371)
@TheNormalnij TheNormalnij deleted the TheNormalnij/building_lods branch May 28, 2024 18:48
@theSarrum theSarrum mentioned this pull request May 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tederis tederis tederis left review comments

@znvjder znvjder znvjder requested changes

@TracerDS TracerDS TracerDS requested changes

@Nico8340 Nico8340 Nico8340 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@TheNormalnij @Dutchman101 @znvjder @tederis @TracerDS @Nico8340