Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message parameter to onPlayerPrivateMessage #3382

Merged
merged 2 commits into from
May 23, 2024

Conversation

FileEX
Copy link
Contributor

@FileEX FileEX commented May 2, 2024

This PR adds a parameter containing only the message content.

string fullMessage, player recipient, string content

Resolved #2135

Copy link
Member

@Lpsd Lpsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please update https://wiki.multitheftauto.com/wiki/OnPlayerPrivateMessage with the new parameter once the nightly build has been generated.

You may want to use the "New feature" block (example), or at-least mention somewhere that the content parameter is only available since r<insert_revision_number>.

@Lpsd Lpsd merged commit 79f8ed6 into multitheftauto:master May 23, 2024
6 checks passed
MTABot pushed a commit that referenced this pull request May 23, 2024
79f8ed6 Add message parameter to onPlayerPrivateMessage  (#3382)
40828d4 Update client en_US pot
@FileEX FileEX deleted the bugfix/onPlayerPrivateMessage branch May 23, 2024 18:02
@TheNormalnij TheNormalnij added this to the 1.6.1 milestone May 25, 2024
@TheNormalnij TheNormalnij added the enhancement New feature or request label May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

onPlayerPrivateMessage returns bad "message" argument
4 participants