Add roadsignstext special world property #3385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nico8340
approved these changes
May 16, 2024
|
Just wanna let you know again that current implementation is not backwards compatible (my comment with details in PR #3365) |
I don't see your comment in that PR |
You need to create new struct for this property and add new eBitStreamVersion in order for it to be backwards compatible. Please look at how "fireballdestruct" is implemented. There are also references to this struct in CMapInfoPacket.cpp and CPacketHandler.cpp |
|
Please update https://wiki.multitheftauto.com/wiki/SetWorldSpecialPropertyEnabled once the next nightly build has been created (after r22420). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
roadsignstextspecial world property, which allows you to disable text rendering on road signs. Thanks to this, we have the opportunity to make our own road signs, which was suggested e.g. in #672Enabled:
Disabled:
