-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(FEAT) Simple file replacement of ogg samples (Replace microphone (de)activation noises that are made with generated noise) #6181
Conversation
renamed on.ogg to on_sweep.ogg renamed off.ogg to off_sweep.ogg added on_noise.ogg added off_noise.ogg
renamed on.ogg to on_sweep.ogg renamed off.ogg to off_sweep.ogg added on_noise.ogg added off_noise.ogg
@Krzmbrzl @davidebeatrici Is there consensus on changing the on and off cues to noise instead of sweep? I personally do not care and I do not use on/off cues. |
I don't mind - haven't listened to the new sounds yet but as long as users can revert back to the old ones if they don't like the new ones, I don't see an issue in just changing them and then see what the community has to say about the change. |
@hvanmegen Sorry that this took so long. Are you still willing to work on this? If so the following needs to be done:
|
I'm still willing to work on it.. I simply lost interest to make the change after I couldn't figure out what I needed to change to get this done and life things got in the way (quarantine at home was no longer a thing & I changed jobs, no longer needing VoIP tools as much). I still think this would be a great feature as being aware of microphone activation is one of the defining advantages that TeamSpeak has for me over Discord.. since I still want to move away from TeamSpeak to Mumble, I would very mucht still like these files to become the default microphone threshold activation and deactivation sounds for Mumble, so I can transition as many people from TeamSpeak to Mumble as I can, but I'm also aware that some people might prefer the older version of the sounds, so some way of adding both would be needed, and not simply replacing the files. -- TL;DR: I'll do my best to find the time to redo the samples and add a third one for microphone muting (complete with a reproduction path for anyone that wants to recreate them) and then I'll try to do the things you suggested in your previous comment. |
I'll close this for now and reopen it with the new ones. |
I was specifically talking about the "mute cue" which is a sound that gets played while you are muted to inform you that no speech is being sent. I feel like the original "off cue" (the bleep sound) is good enough for that so you do not have to re-create that one. |
Ok, I'll focus on just the microphone-on and microphone-off sounds then.. I haven't used the thing, but yeah, a simple bleep thing is fine. It's just that the microphone response sounds really need to be more subtle in order to be useful. |
TYPE(Scope): Replace sound samples ( #5891 )
Did two things:
_sweep
to the name.on_noise.ogg
andoff_noise.ogg
That is all, thank you for considering these new samples.