-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Refactor server database #6263
Draft
Krzmbrzl
wants to merge
249
commits into
mumble-voip:master
Choose a base branch
from
Krzmbrzl:refac-database
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krzmbrzl
force-pushed
the
refac-database
branch
5 times, most recently
from
January 1, 2024 13:39
a26dd78
to
28acdc8
Compare
Krzmbrzl
force-pushed
the
refac-database
branch
from
January 2, 2024 18:32
80c18a6
to
554762f
Compare
Krzmbrzl
force-pushed
the
refac-database
branch
2 times, most recently
from
March 7, 2024 20:00
2a149e9
to
825b6b1
Compare
Krzmbrzl
force-pushed
the
refac-database
branch
3 times, most recently
from
April 6, 2024 15:09
a0b5044
to
0cff06a
Compare
This commit implements a new, Qt-independent mechanism for accessing and handling a database. It fully supports SQLite, MySQL and PostgreSQL.
Each supported backend can be excluded from the build separately
Krzmbrzl
force-pushed
the
refac-database
branch
2 times, most recently
from
May 20, 2024 06:54
3584ad3
to
62ac5fc
Compare
Krzmbrzl
force-pushed
the
refac-database
branch
3 times, most recently
from
June 2, 2024 17:28
a6b38a1
to
5482818
Compare
Krzmbrzl
force-pushed
the
refac-database
branch
5 times, most recently
from
June 6, 2024 17:20
e75bd24
to
8c00f1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completely rewrites the database handling on the server side. In so doing it cleans up and unifies the mess of the current implementation and adds proper unit testing support - in particular for data migration paths, which should provide an overall more reliable experience for users as the tests more or less guarantee that the data migration will work as intended. Additionally, since unit tests are run against all supported backends (SQLite, MySQL, PostgreSQL), all should work equally fine (at least from a functionality point of view).
As a bonus, the dependence on Qt for the database handling is completely removed. Instead, the new framework is built on SOCI.
This PR should address the following issues:
Checks