-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rosonway A10, ST07C as compatible devices #567
Conversation
Hi @mvp If you like, we can trash this MR and I add as issue for each hub I tested. |
1854896
to
698ca6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for late reply, I was traveling. Please address issues below. Thanks for your submission!
README.md
Outdated
@@ -110,8 +110,10 @@ This is list of known compatible USB hubs: | |||
| Rosewill | RHUB-210 | 4 | 2.0 |`0409:005A`| 2011 | 2014 | | |||
| Rosonway | RSH-518C ([note](https://bit.ly/3kYZUsA)) | 7 | 3.0 |`2109:0817`| 2021 | | | |||
| Rosonway | RSH-A13 ([warning](https://bit.ly/3OToUOL)) | 13 | 3.1 |`2109:2822`| 2021 | | | |||
| Rosonway | RSH-A16 ([note](https://git.io/JTawg), [warning](https://bit.ly/39B0tGS)) | 16 | 3.0 |`0bda:0411`| 2020 | | | |||
| Rosonway | RSH-A10 ([see](https://tinyurl.com/2ppyyaj8)) | 10 | 3.0 |`0bda:0411`| 2020 | | | |||
| Rosonway | RSH-A16 ([note](https://git.io/JTawg), [warning](https://bit.ly/39B0tGS), [see](https://tinyurl.com/4ufrdur2)) | 16 | 3.0 |`0bda:0411`| 2020 | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't add more warning links - this is too long already.
Ideally, leave just one warning link.
README.md
Outdated
| Rosonway | RSH-A104 ([USB2 only](https://bit.ly/3A0qiKF)) | 4 | 3.1 |`2109:2822`| 2022 | | | ||
| Rosonway | RSH-ST107C ([only 4](https://tinyurl.com/yjd7fyb6)) | 7 | 3.0 |`2109:2822`| 2023 | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like this has a typo - your link leads to RSH-ST07C, not RSH-ST107C?
README.md
Outdated
@@ -473,6 +475,7 @@ Notable projects using uhubctl | |||
| [Do it yourself PPPS](https://git.io/J3lHs) | Solder wires in your USB hub to support uhubctl | | |||
| [Open source PPPS hub](https://tinyurl.com/yckhystt) | Open source hardware project for uhubctl compatible hub | | |||
| [Python Wrapper for uhubctl](https://github.com/nbuchwitz/python3-uhubctl) | Module to use uhubctl with Python | | |||
| [Wrapper for uhubctl](https://tinyurl.com/2s352y4n) | Specify topology of USB hubs to allow complex setups | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please split this to different PR - adding to list of devices is not the same as adding to list of notable projects.
Also, when you create separate PR, please call it Python Wrapper, not just wrapper. Since there are already two other python wrappers (including different one with the same name as yours: uhubctl), it is good idea to mention that too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your feedback! I update this PR.
698ca6b
to
9587920
Compare
9587920
to
c665849
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for submission!
I tested some Rosonway hubs: A10 works very pleasant. However, the hubs A107 and ST107C use newer chips and may not be recommended for power on/off.