Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(editor): Update paywall states for RBAC #9335

Merged
merged 15 commits into from
May 10, 2024
Merged

fix(editor): Update paywall states for RBAC #9335

merged 15 commits into from
May 10, 2024

Conversation

cstuncsik
Copy link
Contributor

No description provided.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels May 8, 2024
@cstuncsik cstuncsik force-pushed the pay-1524-paywall-states-for-rbac branch from 08ab348 to 8ed4705 Compare May 9, 2024 04:39
@cstuncsik cstuncsik force-pushed the pay-1524-paywall-states-for-rbac branch from 2b7c822 to 0ad6b86 Compare May 9, 2024 14:19
@cstuncsik cstuncsik marked this pull request as ready for review May 10, 2024 10:23
@cypress Cypress
Copy link

cypress bot commented May 10, 2024 •
edited

8 failed and 1 flaky tests on run #4929 ↗︎

8 353 12 0 Flakiness 1

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 cstuncsik 🗃️ e2e/*
Project: n8n Commit: d90491c09d
Status: Failed Duration: 05:47 💡
Started: May 10, 2024 3:15 PM Ended: May 10, 2024 3:21 PM
Failed  cypress/e2e/17-sharing.cy.ts • 8 failed tests

View Output Video

Test Artifacts
Sharing > should create C1, W1, W2, share W1 with U3, as U2 Test Replay Screenshots Video
Sharing > should create C2, share C2 with U1 and U2, as U3 Test Replay Screenshots Video
Sharing > should open W1, add node using C2 as U3 Test Replay Screenshots Video
Sharing > should open W1, add node using C2 as U2 Test Replay Screenshots Video
Sharing > should not have access to W2, as U3 Test Replay Screenshots Video
Sharing > should have access to W1, W2, as U1 Test Replay Screenshots Video
Sharing > should automatically test C2 when opened by U2 sharee Test Replay Screenshots Video
Sharing > should work for admin role on credentials created by others (also can share it with themselves) Test Replay Screenshots Video
Flakiness  cypress/e2e/5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > Stop listening for trigger event from NDV Test Replay Screenshots Video

Review all test suite changes for PR #9335 ↗︎

@github-actions GitHub Actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@krynble krynble merged commit d9d2133 into feature/rbac May 10, 2024
48 of 54 checks passed
@krynble krynble deleted the pay-1524-paywall-states-for-rbac branch May 10, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krynble krynble krynble approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cstuncsik @krynble