Work/string search #2720
Work/string search #2720
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Did you consider using the libc |
|
@Joshua-Anderson I thought about it, but we prefer to use the "n" versions of string functions so they don't run off into space if the null terminator is corrupted. This is a home-grown version with an "n" adaptation, and the code is pretty small too. |
I second this. We should avoid using any string library functions that lack a buffer-bound argument. It looks like there is a |
| FW_ASSERT((source_size - sub_size) <= std::numeric_limits<FwSignedSizeType>::max()); | ||
|
|
||
| // Loop from zero to source_size - sub_size (inclusive) | ||
| for (FwSizeType source_index = 0; |
Check notice
Code scanning / CodeQL
Use of basic integral type Note
| @@ -29,3 +30,45 @@ | |||
| } | |||
| return length; | |||
| } | |||
|
|
|||
| FwSignedSizeType Fw::StringUtils::substring_find(const CHAR* source_string, | |||
Check notice
Code scanning / CodeQL
Use of basic integral type Note
| @@ -29,3 +30,45 @@ | |||
| } | |||
| return length; | |||
| } | |||
|
|
|||
| FwSignedSizeType Fw::StringUtils::substring_find(const CHAR* source_string, | |||
Check notice
Code scanning / CodeQL
Use of basic integral type Note
| @@ -29,3 +30,45 @@ | |||
| } | |||
| return length; | |||
| } | |||
|
|
|||
| FwSignedSizeType Fw::StringUtils::substring_find(const CHAR* source_string, | |||
| FwSizeType source_size, | |||
Check notice
Code scanning / CodeQL
Use of basic integral type Note
|
|
||
| FwSignedSizeType Fw::StringUtils::substring_find(const CHAR* source_string, | ||
| FwSizeType source_size, | ||
| const CHAR* sub_string, |
Check notice
Code scanning / CodeQL
Use of basic integral type Note
| FwSignedSizeType Fw::StringUtils::substring_find(const CHAR* source_string, | ||
| FwSizeType source_size, | ||
| const CHAR* sub_string, | ||
| FwSizeType sub_size) { |
Check notice
Code scanning / CodeQL
Use of basic integral type Note
Change Description
Added a function to
string_utilsto search for a substring in a stringRationale
Centralizes a feature that could be useful to many people.
Testing/Review Recommendations
Future Work
Calling this function will be added to
StringBaseas a helper.