New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow local actions outside the workspace #2108
base: master
Are you sure you want to change the base?
Allow local actions outside the workspace #2108
Conversation
Also simplify actionName logic and ensure it returns sensible values for actions outside the workspace (it's only used for logging and docker image name)
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2108 +/- ##
==========================================
+ Coverage 61.22% 61.64% +0.41%
==========================================
Files 46 53 +7
Lines 7141 8801 +1660
==========================================
+ Hits 4372 5425 +1053
- Misses 2462 2947 +485
- Partials 307 429 +122 ☔ View full report in Codecov by Sentry. |
In my opinion is It doesn't look to be far away from |
For this change we're talking about reading an existing In the absence of being able to use contexts within |
Yes we both have different opinions here... the good thing for you is that my opinion alone doesn't prevent merging this. Keep in mind doing this in monorepos has an old unfixed bug when referencing local actions in actions/runner (those action which has post steps, like actions/cache, actions/checkout): actions/runner#2009, input and outputs end up with wrong values...
I'm awaiting the opinion of the other maintainers if they have any, either way you need another review |
Side note bug 2009 in actions/runner also technically allows endless recursion via local composite actions. I assume act has the same bug, however for both local and remote composite actions. |
Fixes #2107
Also simplify
actionName
logic and ensure it returns sensible values for actions outside the workspace (it's only used for logging and docker image name)