Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect assets mode config in controller #2280

Merged
merged 1 commit into from
May 29, 2024

Conversation

HypeMC
Copy link
Contributor

@HypeMC HypeMC commented Apr 24, 2024

Q A
Bug fix? yes
New feature? no
Deprecations? no
Issues -

Currently the SwaggerUiController doesn't respect the assets_mode configuration added in #2251.

nelmio_api_doc:
  html_config:
    assets_mode: cdn

As far as I can tell, there's no reason for the default any more as it can be set through the configuration and overridden in the DumpCommand command using the html-config option.

@HypeMC HypeMC force-pushed the fix-assets-mode-in-controller branch from 33b9cc4 to bd37679 Compare April 24, 2024 16:10
@DjordyKoert DjordyKoert merged commit 9379c44 into nelmio:master May 29, 2024
12 checks passed
@DjordyKoert
Copy link
Collaborator

Thank you @HypeMC :)

@HypeMC HypeMC deleted the fix-assets-mode-in-controller branch May 29, 2024 07:21
@DominicLuidold
Copy link
Contributor

DominicLuidold commented Jun 3, 2024

First of all: @HypeMC thanks!

Just as a quick side note: this has (unintentionally?) changed the default asset mode to CDN which was a bit unexpected as the release notes didn't mention that change (we noticed as our API docs weren't working in review environments anymore after the update, because the CDN calls got blocked by CSP).

/cc @DjordyKoert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants