fix: Require only DXGI 1.2 when not debugging #2559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredizzimo
force-pushed
the
fsundvik/relax-d3d-requirement
branch
from
b5a39be
to
999818f
Compare
|
I' merged this one, as it was confirmed to fix the problem |
zbyna
pushed a commit
to zbyna/neovide
that referenced
this pull request
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
For some reason it appears like dxgi 1.4 is unavailable on some Windows 10 and Windows 11 machines. I have no idea why, since it should be bundled with Windows since the very first 10 release.
This relaxes those requirements, and also don't pass
DXGI_CREATE_FACTORY_DEBUG, since that's another failure point.Did this PR introduce a breaking change?