fix: Remove reminder action from trash #45227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-merge was automatically disabled
May 7, 2024 22:24
Pull request was converted to draft
Pytal
force-pushed
the
fix/set-reminder-trash
branch
from
027ee2d
to
afb72df
Compare
artonge
reviewed
May 13, 2024
Works this way already actually https://github.com/nextcloud/server/blob/master/apps/files_reminders/lib/Listener/NodeDeletedListener.php |
susnux
reviewed
May 14, 2024
| @@ -32,7 +35,10 @@ export const action = new FileAction({ | |||
| title: () => t('files_reminders', 'Set reminder at custom date & time'), | |||
| iconSvgInline: () => CalendarClockSvg, | |||
|
|
|||
| enabled: () => true, | |||
| enabled: (_nodes: Node[], view: View) => { | |||
There was a problem hiding this comment.
Maybe future APIs should just have context objects to allow to only destructure the needed property
susnux
approved these changes
May 14, 2024
skjnldsv
approved these changes
May 14, 2024
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
force-pushed
the
fix/set-reminder-trash
branch
from
afb72df
to
8138516
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist