fix: Avoid updating size when calling touch on a file #45233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliushaertl
requested review from
Altahrim,
a team,
ArtificialOwl,
yemkareems and
come-nc
and removed request for
a team
joshtrichards
approved these changes
May 10, 2024
come-nc
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to figure out a different issue I noticed that when calling touch to create an empty file we always calculate and update the size of parent folders. However as we know the file is just touched, we can pass the sizeDifference of 0 along for writing the update to the cache to avoid unneeded size calculation/updates.
Earlier change that introduced the shortcut #42597