Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(setupCheck): Only warn when memcache present w/o memcached #45242

Merged
merged 1 commit into from May 13, 2024

Conversation

joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented May 9, 2024

Fixes: https://help.nextcloud.com/t/update-to-28-0-5-memcached-error-now/190125

Summary

Prior to #42812 the check for the common mistake of installing PHP modules memcache rather than memcached only warned if memcached was missing while memcache was installed. When the setup checks were moved to the new API, the logic was changed (probably accidentally) so that it warned anytime memcache was present. This means existing environments started getting a warning about a problem that really isn't a problem.

Restores the old logic. Also removes the old ancient third-party doc link that isn't relevant and only creates confusion. Also tries to make the next step super obvious when this warning is triggered legitimately.

TODO

  • Trigger backport to v29 & v28

Checklist

Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
@joshtrichards
Copy link
Member Author

/backport to stable29

@joshtrichards
Copy link
Member Author

/backport to stable28

@kesselb kesselb merged commit 99f89bb into master May 13, 2024
157 checks passed
@kesselb kesselb deleted the check-memcache-memcached branch May 13, 2024 09:53
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants