fix(SetupChecks): Detect CLI mode in HTTPS / URL generator check #45262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable29 |
|
Hm, I am not fully convinced here, as this check means that the |
|
@susnux You're right; I was looking at this wrong. Still needed adjustment, but a little differently. Updated. Give it another look. |
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
joshtrichards
force-pushed
the
check-HttpsUrlGeneration
branch
from
1736446
to
5b5178a
Compare
susnux
approved these changes
May 13, 2024
come-nc
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Check for CLI mode in the second part of this check rather than return a result we can't be 100% certain about when running the check at the command line.
TODO
Checklist