Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Issue #3105 No error while running selenium-server locally without installing Java first #4063

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SubstantialCattle5
Copy link

@SubstantialCattle5 SubstantialCattle5 commented Feb 27, 2024

fix error - #3105

  • Create a new branch from master (e.g. features/my-new-feature or issue/123-my-bugfix);
  • If you're fixing a bug also create an issue if one doesn't exist yet;
  • If it's a new feature explain why do you think it's necessary. Please check with the maintainers beforehand to make sure it is something that we will accept. Usually we only accept new features if we feel that they will benefit the entire community;
  • Please avoid sending PRs which contain drastic or low level changes. If you are certain that the changes are needed, please discuss them beforehand and indicate what the impact will be;
  • If your change is based on existing functionality please consider refactoring first. Pull requests that duplicate code will most likely be ignored;
  • Do not include changes that are not related to the issue at hand;
  • Follow the same coding style with regards to spaces, semicolons, variable naming etc.;
  • Always add unit tests - PRs without tests are most of the times ignored.

@CLAassistant
Copy link

CLAassistant commented Feb 27, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

Status

  • ❌ No modified files found in the types directory.
    Please make sure to include types for any changes you have made. Thank you!.

@garg3133
Copy link
Member

@SubstantialCattle5 Not having a JAVA_HOME env variable does not necessarily mean that JAVA is not installed in the system. Please thoroughly test your changes before marking the PR as ready for review.

To test it, you could uninstall JAVA from your system and then see where exactly the error is occurring and how can you raise it further. Then try installing JAVA (but without JAVA_HOME env variable) and see what is happening.

You can use VSCode Debugger to follow along the code execution, that helps greatly in understanding the codebase.

@garg3133 garg3133 marked this pull request as draft February 28, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants