-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #23513, parseutils.nim: parseInt's doc example. #23561
base: devel
Are you sure you want to change the base?
Conversation
Its doc used to render wrongly where `>` is considered as quote block.
Also, the old `runnableExample` is just a copy of `proc parseInt(openArray[char], var int, int)` variant (in Line 1000).
doAssert parseInt("-2024_05_02", res) == 11 | ||
doAssert res == -20240502 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to add doc comments that parseInt
in parseutils
and strutils
accept signs and underscores
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mentioned in here I think we shall either:
Footnotes
|
for parseInt/BiggestInt(string,...)
Currently I've added examples for all |
ping @ringabout |
fixes #23513
Also, the old
runnableExample
is just a copy ofproc parseInt(openArray[char], var int, int)
variant (in Line 1000).