Testament: Prevent intermittent permission denied errors on Windows #23605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SirOlaf
changed the title
SirOlaf
changed the title
|
Seems like it does work, haven't observed permission denied since b3008a2 or so. Maybe I've just been getting lucky though, gonna wait and see. |
|
The winlean additions should be moved to testament. |
|
There it goes, it was good while it lasted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wraps windows tests in jobs similar to this old rust issue from 2015 rust-lang/rust#22628
Hard to verify if it actually does anything due to the random nature of these errors. Log is most likely useless because closing job handle kills everything associated anyways.