Added support for isContentEditable #234
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some webpages (Youtube comments for example) use <div> as text input so isContentEditable needs be checked in addition. Relevant minor changes: - Allowed double click to trigger popup in text input elements since it won't interfere with text editing like hotkeys do. - Added a mouse point save before getTranslation() to avoid the triggered popup displaying in somewhere else when the network is slow and the mouse is moved.
- Rectified `exitKey` not being verified (my bad). - Added condition for the timeout to prevent triggering `onSelectionEnd` if there's no text selected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some webpages (YouTube comments for example) use
<div>as text input soisContentEditableneeds be checked in addition.Relevant minor changes:
getTranslation()to avoid the triggered popup displaying in somewhere else when the network is slow and the mouse is moved.onSelectionEndif there's no text selected.