If already a end distance is found, only ways which are shorter are calculated #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Falke-Design
commented
Aug 28, 2022
| parents[child] = node; | ||
|
|
||
| // if already a end distance is found, we allow only ways which are shorter | ||
| if (!distances[endNode] || distances[endNode] > distance) { |
Falke-Design
commented
Aug 28, 2022
| // save the distance to the object but if already a end distance is found, it must be shorter then it | ||
| // record the path | ||
| if ((!distances[child] || distances[child] > newdistance) | ||
| && (!distances[endNode] || distances[endNode] > newdistance)) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your sharing Dijkstra's Algorithm in JavaScript!
I have found a small optimization with a big impact, but I don't know if it is compatible with the "thinking" / "logic" behind Dijkstra's Algorithm.
If already a end distance is found, it don't goes anymore over the node which are farer away then the distance to the end node. This makes it much fast if there are many nodes in the graph.
Current code:
With optimization :
