Nc feat/filter UI #8429
Nc feat/filter UI #8429
Conversation
|
Warning Rate Limit Exceeded@pranavxc has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 6 minutes and 23 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe recent updates aim to enhance the filtering functionality within the application by improving the visibility and focus behaviors of the filter components. The Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- packages/nc-gui/components/smartsheet/toolbar/ColumnFilter.vue (4 hunks)
- packages/nc-gui/composables/useViewFilters.ts (2 hunks)
Additional comments not posted (5)
packages/nc-gui/composables/useViewFilters.ts (2)
209-209: Improved code readability by adding a space after the colon in the ternary operation.
490-490: Improved code readability by adding a space after the colon in the ternary operation.packages/nc-gui/components/smartsheet/toolbar/ColumnFilter.vue (3)
424-426: Enhanced UI control and responsiveness by adding a conditional class and updating the event handler for logical operator changes.
479-479: Enhanced UI responsiveness by adding a conditional class based on user permissions and operational rules.
687-692: Improved visual consistency and usability by adjusting the minimum height of the select element and hiding the select arrow when disabled.
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- packages/nc-gui/components/smartsheet/toolbar/ColumnFilter.vue (5 hunks)
- packages/nc-gui/composables/useViewFilters.ts (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- packages/nc-gui/components/smartsheet/toolbar/ColumnFilter.vue
- packages/nc-gui/composables/useViewFilters.ts
|
Uffizzi Preview |
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- packages/nc-gui/components/smartsheet/toolbar/ColumnFilter.vue (7 hunks)
- packages/nc-gui/composables/useViewFilters.ts (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- packages/nc-gui/components/smartsheet/toolbar/ColumnFilter.vue
- packages/nc-gui/composables/useViewFilters.ts
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- packages/nc-gui/components/smartsheet/toolbar/ColumnFilter.vue (7 hunks)
- packages/nc-gui/composables/useViewFilters.ts (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- packages/nc-gui/components/smartsheet/toolbar/ColumnFilter.vue
- packages/nc-gui/composables/useViewFilters.ts
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- packages/nc-gui/components/smartsheet/toolbar/ColumnFilter.vue (7 hunks)
- packages/nc-gui/composables/useViewFilters.ts (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- packages/nc-gui/components/smartsheet/toolbar/ColumnFilter.vue
- packages/nc-gui/composables/useViewFilters.ts
o1lab
force-pushed
the
nc-feat/filter-ui
branch
2 times, most recently
from
3d0acee
to
9e91dc3
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- packages/nc-gui/components/smartsheet/toolbar/ColumnFilter.vue (12 hunks)
- packages/nc-gui/composables/useViewFilters.ts (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- packages/nc-gui/components/smartsheet/toolbar/ColumnFilter.vue
- packages/nc-gui/composables/useViewFilters.ts
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- packages/nc-gui/components/smartsheet/toolbar/ColumnFilter.vue (12 hunks)
- packages/nc-gui/composables/useViewFilters.ts (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- packages/nc-gui/components/smartsheet/toolbar/ColumnFilter.vue
- packages/nc-gui/composables/useViewFilters.ts
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- packages/nc-gui/components/smartsheet/toolbar/ColumnFilter.vue (12 hunks)
- packages/nc-gui/composables/useViewFilters.ts (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- packages/nc-gui/components/smartsheet/toolbar/ColumnFilter.vue
- packages/nc-gui/composables/useViewFilters.ts
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- packages/nc-gui/components/smartsheet/toolbar/ColumnFilter.vue (11 hunks)
- packages/nc-gui/composables/useViewFilters.ts (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- packages/nc-gui/components/smartsheet/toolbar/ColumnFilter.vue
- packages/nc-gui/composables/useViewFilters.ts
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- packages/nc-gui/components/smartsheet/toolbar/ColumnFilter.vue (11 hunks)
- packages/nc-gui/composables/useViewFilters.ts (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- packages/nc-gui/components/smartsheet/toolbar/ColumnFilter.vue
- packages/nc-gui/composables/useViewFilters.ts
There was a problem hiding this comment.
Actionable comments posted: 1
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- packages/nc-gui/components/smartsheet/toolbar/ColumnFilter.vue (12 hunks)
- packages/nc-gui/components/smartsheet/toolbar/ColumnFilterMenu.vue (1 hunks)
- packages/nc-gui/composables/useViewFilters.ts (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- packages/nc-gui/composables/useViewFilters.ts
Additional comments not posted (2)
packages/nc-gui/components/smartsheet/toolbar/ColumnFilterMenu.vue (1)
84-84: The addition of:is-open="open"to control the visibility of theSmartsheetToolbarColumnFiltercomponent is correctly implemented.Verification successful
The search results from the script indicate that the
openref is indeed used within theColumnFilterMenu.vuecomponent. Here's a breakdown of the usage:
- Initialization:
const open = ref(false)- This line initializes theopenref with a default value offalse, indicating that the component is closed by default.- Functionality:
useMenuCloseOnEsc(open)- This function likely handles the logic to close the menu when the escape key is pressed, utilizing theopenref to control the visibility state.- State Change:
open.value = true- This line explicitly sets theopenvalue totrue, which is typically done to open the menu.- Data Binding:
v-model:visible="open"- This binds the visibility of some part of the component to theopenref, ensuring that changes toopenwill reflect in the component's visibility.- Property Binding:
:is-open="open"- This passes theopenref as a prop to another component or element, likely to control its visibility as well.Based on this information, it appears that the
openref is actively managed and used appropriately within the component to control visibility and interaction behaviors. The addition of:is-open="open"is consistent with the usage pattern of theopenref and seems to be correctly implemented.Final Response:
The usage of the
openref in theColumnFilterMenu.vuecomponent is well-managed and correctly implemented to control the visibility of theSmartsheetToolbarColumnFiltercomponent. The addition of the:is-open="open"property aligns with the existing management of theopenstate.
- Proper initialization and state management of
openref.- Correct implementation of visibility control through
v-model:visibleand:is-open.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the `open` ref is managed correctly in the `ColumnFilterMenu.vue` component. # Test: Search for the usage of the `open` ref. Expect: Proper management of the `open` state. rg --type vue $'open' packages/nc-gui/components/smartsheet/toolbar/ColumnFilterMenu.vueLength of output: 115
Script:
#!/bin/bash # Description: Verify that the `open` ref is managed correctly in the `ColumnFilterMenu.vue` component. # Test: Search for the usage of the `open` ref. Expect: Proper management of the `open` state. rg 'open' packages/nc-gui/components/smartsheet/toolbar/ColumnFilterMenu.vueLength of output: 197
packages/nc-gui/components/smartsheet/toolbar/ColumnFilter.vue (1)
14-14: Addition ofisOpen?: booleanto thePropsinterface is correctly implemented to enhance component interactivity.
There was a problem hiding this comment.
Actionable comments posted: 1
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- packages/nc-gui/components/smartsheet/toolbar/ColumnFilter.vue (12 hunks)
- packages/nc-gui/components/smartsheet/toolbar/ColumnFilterMenu.vue (1 hunks)
- packages/nc-gui/composables/useViewFilters.ts (1 hunks)
- tests/playwright/pages/Dashboard/common/Toolbar/Filter.ts (1 hunks)
Files skipped from review as they are similar to previous changes (3)
- packages/nc-gui/components/smartsheet/toolbar/ColumnFilter.vue
- packages/nc-gui/components/smartsheet/toolbar/ColumnFilterMenu.vue
- packages/nc-gui/composables/useViewFilters.ts
There was a problem hiding this comment.
Actionable comments posted: 3
Out of diff range and nitpick comments (1)
packages/nc-gui/components/smartsheet/toolbar/ColumnFilter.vue (1)
Line range hint
752-865: Consider using CSS variables for colors and spacing to maintain consistency and improve maintainability..nc-filter-wrapper { @apply bg-white !rounded-lg border-1px border-[#E7E7E9]; --border-color: #E7E7E9; --bg-color: white; }
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- packages/nc-gui/components/smartsheet/toolbar/ColumnFilter.vue (12 hunks)
- packages/nc-gui/components/smartsheet/toolbar/ColumnFilterMenu.vue (1 hunks)
- packages/nc-gui/composables/useViewFilters.ts (1 hunks)
- tests/playwright/pages/Dashboard/common/Toolbar/Filter.ts (1 hunks)
Files skipped from review as they are similar to previous changes (3)
- packages/nc-gui/components/smartsheet/toolbar/ColumnFilterMenu.vue
- packages/nc-gui/composables/useViewFilters.ts
- tests/playwright/pages/Dashboard/common/Toolbar/Filter.ts
Additional comments not posted (1)
packages/nc-gui/components/smartsheet/toolbar/ColumnFilter.vue (1)
374-375: Ensure that thesaveOrUpdatefunction handles all necessary conditions previously managed byfilterUpdateCondition.Verification successful
The
saveOrUpdatefunction inuseViewFilters.tshandles various conditions, including undo functionality, nested mode, API calls for creating and updating filters, error handling, and data reloading. This confirms that it manages all necessary conditions previously handled byfilterUpdateCondition.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the implementation of the `saveOrUpdate` function. # Test: Search for the `saveOrUpdate` function implementation. Expect: Proper handling of all conditions. rg --type vue $'saveOrUpdate'Length of output: 56
Script:
#!/bin/bash # Description: Verify the implementation of the `saveOrUpdate` function. # Test: Search for the `saveOrUpdate` function implementation. Expect: Proper handling of all conditions. rg 'saveOrUpdate'Length of output: 4763
Script:
#!/bin/bash # Description: Extract the implementation of the `saveOrUpdate` function from `useViewFilters.ts`. # Test: Extract the `saveOrUpdate` function implementation. ast-grep --lang typescript --pattern $'const saveOrUpdate = async ($_) => { $$$ }' packages/nc-gui/composables/useViewFilters.tsLength of output: 131
Script:
#!/bin/bash # Description: Extract the implementation of the `saveOrUpdate` function from `useViewFilters.ts`. # Test: Extract the `saveOrUpdate` function implementation. ast-grep --lang typescript --pattern $'const saveOrUpdate = async function($_) { $$$ }' packages/nc-gui/composables/useViewFilters.tsLength of output: 136
Script:
#!/bin/bash # Description: Search for the `saveOrUpdate` function definition in `useViewFilters.ts`. # Test: Search for the `saveOrUpdate` function definition. rg 'const saveOrUpdate' packages/nc-gui/composables/useViewFilters.tsLength of output: 251
Script:
#!/bin/bash # Description: Extract the full implementation of the `saveOrUpdate` function from `useViewFilters.ts`. # Test: Extract the lines of code for the `saveOrUpdate` function. rg -A 20 'const saveOrUpdate = async (filter: Filter, i: number, force = false, undo = false, skipDataReload = false) =>' packages/nc-gui/composables/useViewFilters.tsLength of output: 169
Script:
#!/bin/bash # Description: Extract the full implementation of the `saveOrUpdate` function from `useViewFilters.ts`. # Test: Extract the lines of code for the `saveOrUpdate` function. rg -A 50 'const saveOrUpdate = async' packages/nc-gui/composables/useViewFilters.tsLength of output: 1827
Script:
#!/bin/bash # Description: Extract the full implementation of the `saveOrUpdate` function from `useViewFilters.ts`. # Test: Extract more lines of code for the `saveOrUpdate` function. rg -A 100 'const saveOrUpdate = async' packages/nc-gui/composables/useViewFilters.tsLength of output: 3418
There was a problem hiding this comment.
Actionable comments posted: 3
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- packages/nc-gui/components/smartsheet/toolbar/ColumnFilter.vue (13 hunks)
- packages/nc-gui/components/smartsheet/toolbar/ColumnFilterMenu.vue (1 hunks)
- tests/playwright/pages/Dashboard/common/Toolbar/Filter.ts (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- packages/nc-gui/components/smartsheet/toolbar/ColumnFilterMenu.vue
- tests/playwright/pages/Dashboard/common/Toolbar/Filter.ts
Additional comments not posted (2)
packages/nc-gui/components/smartsheet/toolbar/ColumnFilter.vue (2)
405-415: The focus logic implemented to enhance user experience by focusing the add button when the component is reopened is a good practice.
426-476: The template updates are consistent and follow best practices. Ensure all new elements and event handlers are tested thoroughly.Also applies to: 480-750
There was a problem hiding this comment.
Actionable comments posted: 5
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- packages/nc-gui/components/smartsheet/toolbar/ColumnFilter.vue (13 hunks)
- packages/nc-gui/components/smartsheet/toolbar/ColumnFilterMenu.vue (1 hunks)
- packages/nc-gui/components/smartsheet/toolbar/FieldListAutoCompleteDropdown.vue (1 hunks)
- tests/playwright/pages/Dashboard/common/Toolbar/Filter.ts (1 hunks)
Files skipped from review as they are similar to previous changes (3)
- packages/nc-gui/components/smartsheet/toolbar/ColumnFilterMenu.vue
- packages/nc-gui/components/smartsheet/toolbar/FieldListAutoCompleteDropdown.vue
- tests/playwright/pages/Dashboard/common/Toolbar/Filter.ts
| <div v-if="nested" class="flex w-full items-center mb-2"> | ||
| <div :class="[`nc-filter-logical-op-level-${nestedLevel}`]"><slot name="start"></slot></div> | ||
| <div class="flex-grow"></div> | ||
| <NcDropdown :trigger="['hover']" overlay-class-name="nc-dropdown-filter-group-sub-menu"> | ||
| <GeneralIcon icon="plus" class="cursor-pointer" /> | ||
|
|
||
| <template #overlay> | ||
| <NcMenu> | ||
| <template v-if="isEeUI && !isPublic"> | ||
| <template v-if="filtersCount < getPlanLimit(PlanLimitTypes.FILTER_LIMIT)"> | ||
| <NcMenuItem @click.stop="addFilter()"> | ||
| <div class="flex items-center gap-1"> | ||
| <component :is="iconMap.plus" /> | ||
| <!-- Add Filter --> | ||
| {{ $t('activity.addFilter') }} | ||
| </div> | ||
| </NcMenuItem> | ||
|
|
||
| <NcMenuItem v-if="nestedLevel < 5" @click.stop="addFilterGroup()"> | ||
| <div class="flex items-center gap-1"> | ||
| <!-- Add Filter Group --> | ||
| <component :is="iconMap.plusSquare" /> | ||
| {{ $t('activity.addFilterGroup') }} | ||
| </div> | ||
| </NcMenuItem> | ||
| </template> | ||
| </template> | ||
| <template v-else> | ||
| <NcMenuItem @click.stop="addFilter()"> | ||
| <div class="flex items-center gap-1"> | ||
| <component :is="iconMap.plus" /> | ||
| <!-- Add Filter --> | ||
| {{ $t('activity.addFilter') }} | ||
| </div> | ||
| </NcMenuItem> | ||
|
|
||
| <NcButton v-if="!webHook && nestedLevel < 5" @click.stop="addFilterGroup()"> | ||
| <div class="flex items-center gap-1"> | ||
| <!-- Add Filter Group --> | ||
| <component :is="iconMap.plusSquare" /> | ||
| {{ $t('activity.addFilterGroup') }} | ||
| </div> | ||
| </NcButton> | ||
| </template> | ||
| </NcMenu> | ||
| </template> | ||
| </NcDropdown> |
There was a problem hiding this comment.
Ensure that the NcDropdown component has proper accessibility attributes, such as aria-haspopup and aria-expanded, to improve accessibility.
<NcDropdown :trigger="['hover']" overlay-class-name="nc-dropdown-filter-group-sub-menu" aria-haspopup="true" aria-expanded="false">Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| <div v-if="nested" class="flex w-full items-center mb-2"> | |
| <div :class="[`nc-filter-logical-op-level-${nestedLevel}`]"><slot name="start"></slot></div> | |
| <div class="flex-grow"></div> | |
| <NcDropdown :trigger="['hover']" overlay-class-name="nc-dropdown-filter-group-sub-menu"> | |
| <GeneralIcon icon="plus" class="cursor-pointer" /> | |
| <template #overlay> | |
| <NcMenu> | |
| <template v-if="isEeUI && !isPublic"> | |
| <template v-if="filtersCount < getPlanLimit(PlanLimitTypes.FILTER_LIMIT)"> | |
| <NcMenuItem @click.stop="addFilter()"> | |
| <div class="flex items-center gap-1"> | |
| <component :is="iconMap.plus" /> | |
| <!-- Add Filter --> | |
| {{ $t('activity.addFilter') }} | |
| </div> | |
| </NcMenuItem> | |
| <NcMenuItem v-if="nestedLevel < 5" @click.stop="addFilterGroup()"> | |
| <div class="flex items-center gap-1"> | |
| <!-- Add Filter Group --> | |
| <component :is="iconMap.plusSquare" /> | |
| {{ $t('activity.addFilterGroup') }} | |
| </div> | |
| </NcMenuItem> | |
| </template> | |
| </template> | |
| <template v-else> | |
| <NcMenuItem @click.stop="addFilter()"> | |
| <div class="flex items-center gap-1"> | |
| <component :is="iconMap.plus" /> | |
| <!-- Add Filter --> | |
| {{ $t('activity.addFilter') }} | |
| </div> | |
| </NcMenuItem> | |
| <NcButton v-if="!webHook && nestedLevel < 5" @click.stop="addFilterGroup()"> | |
| <div class="flex items-center gap-1"> | |
| <!-- Add Filter Group --> | |
| <component :is="iconMap.plusSquare" /> | |
| {{ $t('activity.addFilterGroup') }} | |
| </div> | |
| </NcButton> | |
| </template> | |
| </NcMenu> | |
| </template> | |
| </NcDropdown> | |
| <div v-if="nested" class="flex w-full items-center mb-2"> | |
| <div :class="[`nc-filter-logical-op-level-${nestedLevel}`]"><slot name="start"></slot></div> | |
| <div class="flex-grow"></div> | |
| <NcDropdown :trigger="['hover']" overlay-class-name="nc-dropdown-filter-group-sub-menu" aria-haspopup="true" aria-expanded="false"> | |
| <GeneralIcon icon="plus" class="cursor-pointer" /> | |
| <template #overlay> | |
| <NcMenu> | |
| <template v-if="isEeUI && !isPublic"> | |
| <template v-if="filtersCount < getPlanLimit(PlanLimitTypes.FILTER_LIMIT)"> | |
| <NcMenuItem @click.stop="addFilter()"> | |
| <div class="flex items-center gap-1"> | |
| <component :is="iconMap.plus" /> | |
| <!-- Add Filter --> | |
| {{ $t('activity.addFilter') }} | |
| </div> | |
| </NcMenuItem> | |
| <NcMenuItem v-if="nestedLevel < 5" @click.stop="addFilterGroup()"> | |
| <div class="flex items-center gap-1"> | |
| <!-- Add Filter Group --> | |
| <component :is="iconMap.plusSquare" /> | |
| {{ $t('activity.addFilterGroup') }} | |
| </div> | |
| </NcMenuItem> | |
| </template> | |
| </template> | |
| <template v-else> | |
| <NcMenuItem @click.stop="addFilter()"> | |
| <div class="flex items-center gap-1"> | |
| <component :is="iconMap.plus" /> | |
| <!-- Add Filter --> | |
| {{ $t('activity.addFilter') }} | |
| </div> | |
| </NcMenuItem> | |
| <NcButton v-if="!webHook && nestedLevel < 5" @click.stop="addFilterGroup()"> | |
| <div class="flex items-center gap-1"> | |
| <!-- Add Filter Group --> | |
| <component :is="iconMap.plusSquare" /> | |
| {{ $t('activity.addFilterGroup') }} | |
| </div> | |
| </NcButton> | |
| </template> | |
| </NcMenu> | |
| </template> | |
| </NcDropdown> |
There was a problem hiding this comment.
This we have to do with all existing NcDropdown or a-dropdown usage so we can do it later.
There was a problem hiding this comment.
@pranavxc, understood! It sounds like a plan to enhance accessibility across all dropdown components in a future update. If you need any assistance or reminders when you decide to implement these changes, feel free to reach out. Happy coding! 🚀
There was a problem hiding this comment.
@pranavxc, I can help by creating a GitHub issue to serve as a reminder for enhancing accessibility across all dropdown components. This issue can include all the necessary details and can be labeled for easy tracking. Would you like me to go ahead and create this issue for you?
There was a problem hiding this comment.
Actionable comments posted: 5
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- packages/nc-gui/components/smartsheet/toolbar/ColumnFilter.vue (13 hunks)
- packages/nc-gui/components/smartsheet/toolbar/ColumnFilterMenu.vue (1 hunks)
- packages/nc-gui/components/smartsheet/toolbar/FieldListAutoCompleteDropdown.vue (1 hunks)
- packages/nc-gui/composables/useViewFilters.ts (1 hunks)
- tests/playwright/pages/Dashboard/common/Toolbar/Filter.ts (1 hunks)
Files skipped from review as they are similar to previous changes (4)
- packages/nc-gui/components/smartsheet/toolbar/ColumnFilterMenu.vue
- packages/nc-gui/components/smartsheet/toolbar/FieldListAutoCompleteDropdown.vue
- packages/nc-gui/composables/useViewFilters.ts
- tests/playwright/pages/Dashboard/common/Toolbar/Filter.ts
…pleteDropdown.vue Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- packages/nc-gui/components/smartsheet/toolbar/FieldListAutoCompleteDropdown.vue (1 hunks)
- tests/playwright/pages/Dashboard/common/Toolbar/Filter.ts (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- packages/nc-gui/components/smartsheet/toolbar/FieldListAutoCompleteDropdown.vue
- tests/playwright/pages/Dashboard/common/Toolbar/Filter.ts
Signed-off-by: Pranav C <pranavxc@gmail.com>
Signed-off-by: Pranav C <pranavxc@gmail.com>
Change Summary
Provide summary of changes with issue number if any.
Change type
Test/ Verification
Provide summary of changes.
Additional information / screenshots (optional)
Anything for maintainers to be made aware of